Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MEA PHE tests failing with Pyomo 6.7.0 #1294

Open
lbianchi-lbl opened this issue Nov 30, 2023 · 4 comments
Open

MEA PHE tests failing with Pyomo 6.7.0 #1294

lbianchi-lbl opened this issue Nov 30, 2023 · 4 comments
Assignees
Labels
bug Something isn't working Priority:Normal Normal Priority Issue or PR

Comments

@lbianchi-lbl
Copy link
Contributor

lbianchi-lbl commented Nov 30, 2023

Observed on:

  • Windows (GHA)
  • Linux (by @andrewlee94 on his local machine)
FAILED idaes/models_extra/column_models/tests/test_plate_heat_exchanger.py::TestPHE::test_solve - AssertionError
FAILED idaes/models_extra/column_models/tests/test_plate_heat_exchanger.py::TestPHE::test_solution - AssertionError
FAILED idaes/models_extra/column_models/tests/test_plate_heat_exchanger.py::TestPHE::test_conservation - AssertionError
@lbianchi-lbl lbianchi-lbl added the bug Something isn't working label Nov 30, 2023
@andrewlee94
Copy link
Member

Initial symptoms suggest a scaling issue (platform dependent failures). Further investigations (using a local Linux build that fails) showed:

  • The associated change in Pyomo should only change variable ordering, which is observed.
  • However, inspecting the NL file also showed that the solution from the model initialization was significantly different, indicating that the source of the problem occurs during initialization.

@dallan-keylogic
Copy link
Contributor

Unable to reproduce problem on my machine. @jsiirola suggested checking whether Pyomo presolve to remove trivial equality constraints might make this problem go away on its own.

@lbianchi-lbl
Copy link
Contributor Author

No progress on this as of today.

@ksbeattie ksbeattie added Priority:Normal Normal Priority Issue or PR and removed Priority:High High Priority Issue or PR labels Jan 25, 2024
@dallan-keylogic
Copy link
Contributor

Need to try running this after the new Pyomo release when the presolve is added. Note that we might need to manually enable the presolve initially.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Priority:Normal Normal Priority Issue or PR
Projects
None yet
Development

No branches or pull requests

4 participants