Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

idaes get-extensions: All unidentified Linux distributions default to Ubuntu? #1456

Open
mrmundt opened this issue Jul 23, 2024 · 5 comments
Assignees
Labels
Priority:High High Priority Issue or PR

Comments

@mrmundt
Copy link
Contributor

mrmundt commented Jul 23, 2024

Hello, lovely IDAES folks!

We have a new performance machine that runs on RHEL9, and RHEL9 binaries are not currently being released. No problem - it is what it is.

However, the default version pulled is ubuntu2204. It seems more logical that it should instead pull the most recent RHEL distribution (in this case, RHEL8).

Here is the output for your perusal:

08:19:00 # Running 'idaes get-extensions'
08:19:00 #
08:19:04 Getting files...
08:19:04 DEBUG   idaes.commands.util.download_bin: Detected Linux distribution: rhel9
08:19:04 DEBUG   idaes.commands.util.download_bin: Downloading binaries for ubuntu2204-x86_64
08:19:04 DEBUG   idaes.commands.util.download_bin: Downloading binaries from https://github.com/IDAES/idaes-ext/releases/download/3.4.0
08:19:04 DEBUG   idaes.commands.util.download_bin: Getting checksum file https://raw.githubusercontent.com/IDAES/idaes-ext/main/releases/sha256sum_3.4.0.txt
08:19:04 DEBUG   idaes.commands.util.download_bin: Getting petsc from: https://github.com/IDAES/idaes-ext/releases/download/3.4.0/idaes-petsc-ubuntu2204-x86_64.tar.gz
08:19:04 DEBUG   idaes.commands.util.download_bin: Saving solvers to: /workspace/.idaes/bin/idaes-petsc-ubuntu2204-x86_64.tar.gz
08:19:09 DEBUG   idaes.commands.util.download_bin: Getting lib from: https://github.com/IDAES/idaes-ext/releases/download/3.4.0/idaes-lib-ubuntu2204-x86_64.tar.gz
08:19:09 DEBUG   idaes.commands.util.download_bin: Saving solvers to: /workspace/.idaes/bin/idaes-lib-ubuntu2204-x86_64.tar.gz
08:19:10 DEBUG   idaes.commands.util.download_bin: Getting solvers from: https://github.com/IDAES/idaes-ext/releases/download/3.4.0/idaes-solvers-ubuntu2204-x86_64.tar.gz
08:19:10 DEBUG   idaes.commands.util.download_bin: Saving solvers to: /workspace/.idaes/bin/idaes-solvers-ubuntu2204-x86_64.tar.gz
08:19:15 DEBUG   idaes.commands.util.download_bin: petsc Hash 9dd59625270520f9fd897d65cc73e5d4d34f53ef04ea86124c4f9562acef8d6d
08:19:15 DEBUG   idaes.commands.util.download_bin: lib Hash 3dca91e69b58c8dfd19b172dbfb4dd94476ab109c4531a89b1702798cd9a6bf1
08:19:15 DEBUG   idaes.commands.util.download_bin: solvers Hash 5a54bf5f3b54a9faa1db6515939fa281e8cdf7261c12c7e64df1b71597f068a6
08:19:15 DEBUG   idaes.commands.util.download_bin: Extracting files in /workspace/.idaes/bin/idaes-petsc-ubuntu2204-x86_64.tar.gz to /workspace/.idaes/bin
08:19:15 DEBUG   idaes.commands.util.download_bin: Extracting files in /workspace/.idaes/bin/idaes-lib-ubuntu2204-x86_64.tar.gz to /workspace/.idaes/bin
08:19:15 DEBUG   idaes.commands.util.download_bin: Extracting files in /workspace/.idaes/bin/idaes-solvers-ubuntu2204-x86_64.tar.gz to /workspace/.idaes/bin
@Robbybp
Copy link
Member

Robbybp commented Jul 23, 2024

This appears to be hard-coded in idaes.config, I'll open a PR

@lbianchi-lbl
Copy link
Contributor

@mrmundt Would you be able to try if #1457 works (i.e. results in the RHEL8 binaries being installed by default) on your machine? The following should install IDAES directly from that PR's branch:

pip install "git+https://github.com/IDAES/idaes-pse@refs/pull/1457/merge"
idaes get-extensions --verbose

@ksbeattie ksbeattie added the Priority:High High Priority Issue or PR label Jul 25, 2024
@ksbeattie
Copy link
Member

So should the behavior be that it should fail if the platform is unknown (with a helpful message as to what to do)?

@ksbeattie
Copy link
Member

@mrmundt volunteered do to this!

@ksbeattie
Copy link
Member

This is part of IDAES/idaes-ext#274

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority:High High Priority Issue or PR
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants