Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Channel mapper implementation has error #361

Open
JohnMBrandt opened this issue Aug 15, 2024 · 0 comments
Open

Channel mapper implementation has error #361

JohnMBrandt opened this issue Aug 15, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@JohnMBrandt
Copy link

JohnMBrandt commented Aug 15, 2024

Many DETR models use group normalization within channel mapper (e.g. DINO, DETA, etc.).

The implementation of channel mapper in this repo defaults bias = True, which is not best practice since group normalization has its own bias term.

In contrast, the channel mapper implementation in MMDetection relies on mmcv.ConvModule, which turns bias to False if a norm layer is attached (https://mmcv.readthedocs.io/en/2.x/api/generated/mmcv.cnn.ConvModule.html).

Suggest either turning bias to False by default, or updating the model configs that use ChannelMapper with group norm to have bias=False

In practice I get ~0.3 - 0.6 AP improvement from this

@rentainhe rentainhe added the enhancement New feature or request label Aug 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants