Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve the skim option in the 2/3 Variable summarise dialog #9252

Open
rdstern opened this issue Nov 13, 2024 · 6 comments
Open

Improve the skim option in the 2/3 Variable summarise dialog #9252

rdstern opened this issue Nov 13, 2024 · 6 comments
Assignees
Labels
Milestone

Comments

@rdstern
Copy link
Collaborator

rdstern commented Nov 13, 2024

@Vitalis95 this is the same dialog as you are trying to finalise. I hope the suggested corrections will be simple to add, and you might include them as you finish the 3-variable case. But they should not distrcat you too much, so you may want to consider them as a separate pull request later.

a) The dialog works, but does not "remember" the numeric items in the multiple receiver. They seem to be cleared when you return to the dialog.
b) And the second receiver has the focus when you return, not the first.

Lastly a question for @Patowhiz ,partly because it may be more general than this dialog.
The default output for numeric columns is a bit of a mess, see below:

image

There is one really simple solution - in Rstudio. This is mentioned in the skimR documentation. It is to give the options command, e.g

options (width=120)

This also works fine in R-Instat - as a command (one-line script) Then I get:

image

which is a lot nicer!

@Patowhiz How should we do this in R-Instat. I assume the default is 80. Is there any reason to have that as the R-Instat default, or what should we do?

@rdstern rdstern added the bug label Nov 13, 2024
@rdstern rdstern added this to the 0.8.0 milestone Nov 13, 2024
@Patowhiz
Copy link
Contributor

@rdstern as shown in the screenshot below, the Tools > options dialog is responsible for the R options(). The control is currently limited to 22, I'm not sure why or when this was changed. Note also the command produced after the changes to the number of digits to display is incorrect and will have to be solved first so that a user can to be able to change the options using the GUI. As I explained in this comment the command is also incorrect during R-Instat startup. Would be good to see this solved together with this issue.

options

@rdstern
Copy link
Collaborator Author

rdstern commented Nov 17, 2024

@Patowhiz I don't quite understand, but happy that others do, and will make the improvement.
Then how do you suggest the skim issue be solved. I wrote "I assume the default is 80. Is there any reason to have that as the R-Instat default, or what should we do?"

Am I right, this is the default. If so, then where is it set? And would there be any harm making it 120 for now, which would solve my skim issue for most data sets? I would like users to be able to avoid the tools menu if possible - especially for commands like skim, that are for beginners.

@Patowhiz
Copy link
Contributor

@rdstern the default is what is shown in the options screenshot above. You can access it in your R-Insat version.

@N-thony I think someone can address the defaults that @rdstern wants, after evaluation of the current default.

@rdstern yes, it can be changed, currently it is hard coded so it's just a matter of code changes.

@rdstern
Copy link
Collaborator Author

rdstern commented Nov 17, 2024

@Patowhiz thanks, but the screenshot only shows the precision of data to be used, which is fine. I didn't see the number of characters in the line. Could you mark that as well? I expected 80 somewhere?

@N-thony
Copy link
Collaborator

N-thony commented Nov 18, 2024

@Patowhiz thanks, but the screenshot only shows the precision of data to be used, which is fine. I didn't see the number of characters in the line. Could you mark that as well? I expected 80 somewhere?

@Vitalis95 will work on it.

@Patowhiz
Copy link
Contributor

@rdstern oh yes, that width option will have to be added in the Tools > Options dialog. Your default width can also be added set up when R-Instat initialises R. That's what I meant. You can suggest where the width option should be added.

@N-thony @Vitalis95 @rdstern I suggest separating options issue from the 2/3 variable issues, and having 2 different PRs to ease review and testing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants