-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Possible spec language for reading system CSS handling #693
Comments
What about something stronger
(I trie to avoid using element level style elements…)
|
What jumps out to me is SHOULD in #1. If one of the goals is to provide a reliable CSS foundation for ebook developers to build their own styles over, something that "might" be there isn't a reliable foundation and so ultimately just isn't useful for ebook developers. Plus, since AFAIK no popular RS currently implements the HTML5 defaults, why should they expend the effort to implement a "should"? (Though of course we must acknowledge that even a "must" can and very well might be ignored.) |
Also want to add that the rest looks good and would be a big step forward for us poor ebook developers :) |
OK so, that’s not necessarily feedback on pure language but I'll try not to spill over too much.
|
|
At Kobo we'd like to align ourselves with efforts to improve CSS support. What would help us get started is a sample ePub that makes use of all the CSS content creators would like to see supported (or not overwritten). One of the difficulties with improving CSS support is that there are so many possible attributes. Having content creation experts come up with a list of what they want to see supported everywhere and then making a sample that uses them would allow us to run testing across all our platforms then create a support grid. |
@bdugas Thanks a lot for your input. Please feel free to DM me on twitter if needed. Firstly, what I can personally do is to provide a sample based on the Blitz framework we've been developing. But I guess it won't be very meaningful since we've been basically trying to get around anything which might be an issue. At least we're covering a lot of stuff (tags, CSS, etc.) so that's already something. Then, I'll try to review all the files I've made so far and create a sample with common and edge cases which have proven to be problematic. I'll need some time though since that is quite a lot of files. Finally, since it is quite impossible for one single individual to provide some comprehensive sample, I guess it would be useful if someone started some repo to compile problematic snippets of markup and CSS then build an epub file out of them? Obviously, this would be a great effort and in order to motivate people to get involved, I'm not sure one single individual is up to the task…. |
@JayPanoz I'd be curious to see the file you can export now even if it's not the ultimate CSS test ePub we're seeking. We'd certainly be interested in working as a group to identify the CSS elements to be tested. |
OK so just to illustrate how the CSS issue could turn into a huge problem really fast, I've tested For instance, Google Play Books doesn't know how to manage them, the user can't increase or decrease font-size (as if you've got pixels in IE 6) and, even worse, the cloud reader reflows margins instead of font-size, which means the smaller the font-size, the larger the margins. Others like ADE 4.5 have, by default,
which means you must declare:
Or else… while it should be Of course, if they “!important” their own declaration, then you’re toast. So I get why RS want this to be "should" and why they are doing this in the first place (because sometimes authors set body copy to 10px) but on the other hand, if that breaks CSS units (units!), we're heading for serious issues. Indeed, using |
But this doesn't sound like a problem with rem units, it sounds like a problem with font size changes. We use at least three different approaches to zoom fonts, based on the platform, and they all have their weird quirks. And that is specifically a case where doing something (changing font size) with just CSS is essentially impossible. There are some mobile hacks to do it (text-size-adjust), but that isn't available everywhere, so we are forced into these games of programmatically changing the font size. It also means (in some case) making sure there is at least one font size on the body, though I don't think we ever do that with !important and do it before any publisher CSS, so it should only take effect if no font size was specified by the publisher. I expect this specific case is just a bug, perhaps in only some of the readers (it's jot clear which ones you tested, other than the webreader). Personally, I would much rather not play these games just to enable font size changes, but I am also not sure what the alternative is. |
Closing as we how have spec language that's had quite a bit of review. |
During the Bordeaux F2F, we decided on some "baby steps" to begin to address the relationship between author stylesheets, reading system defaults, and "overrides." [See #672]. We understand this will not solve the many complex problems in this area, but will continue to work on these issues. In the meantime, here is some possible spec language for EPUB 3.1:
Feedback on the language would be most welcome. I expect we need more details for 3.
The text was updated successfully, but these errors were encountered: