Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat pro textarea saller #1080

Merged
merged 1 commit into from
Aug 18, 2022
Merged

Conversation

sallerli1
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our guidelines
  • Tests for the changes have been added/updated or not needed
  • Docs and demo have been added/updated or not needed

What is the current behavior?

在比较小的line-height下,textarea元素出现了滚动条

What is the new behavior?

由于内置设置了autoRows: true, 修改overflow为 hidden

Other information

重构部分实现,去掉无用注释

@idux-bot
Copy link

idux-bot bot commented Aug 18, 2022

This preview will be available after the AzureCI is passed.

@codecov
Copy link

codecov bot commented Aug 18, 2022

Codecov Report

Merging #1080 (47f30df) into main (dcb28b1) will increase coverage by 0.05%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1080      +/-   ##
==========================================
+ Coverage   96.87%   96.92%   +0.05%     
==========================================
  Files         317      317              
  Lines       30484    30398      -86     
  Branches     2790     2790              
==========================================
- Hits        29530    29463      -67     
+ Misses        954      935      -19     
Impacted Files Coverage Δ
packages/pro/textarea/src/ProTextarea.tsx 100.00% <ø> (+7.59%) ⬆️
packages/components/textarea/src/Textarea.tsx 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@danranVm danranVm merged commit de7cc60 into IDuxFE:main Aug 18, 2022
@sallerli1 sallerli1 deleted the feat-pro-textarea-saller branch February 20, 2023 06:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants