Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(comp:upload): actions and files are optional #1128

Merged
merged 1 commit into from
Sep 27, 2022

Conversation

typistZxd
Copy link
Member

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our guidelines
  • Tests for the changes have been added/updated or not needed
  • Docs and demo have been added/updated or not needed

What is the current behavior?

action和files必须

What is the new behavior?

action和files非必须

Other information

@idux-bot
Copy link

idux-bot bot commented Sep 8, 2022

This preview will be available after the AzureCI is passed.

@codecov
Copy link

codecov bot commented Sep 8, 2022

Codecov Report

Merging #1128 (943f480) into main (7f656fc) will decrease coverage by 0.15%.
The diff coverage is 100.00%.

❗ Current head 943f480 differs from pull request most recent head cbe2769. Consider uploading reports for the commit cbe2769 to get more accurate results

@@            Coverage Diff             @@
##             main    #1128      +/-   ##
==========================================
- Coverage   96.94%   96.79%   -0.16%     
==========================================
  Files         321      321              
  Lines       30906    30792     -114     
  Branches     2070     2801     +731     
==========================================
- Hits        29962    29804     -158     
- Misses        944      988      +44     
Impacted Files Coverage Δ
packages/components/upload/src/types.ts 100.00% <100.00%> (ø)
packages/cdk/scroll/src/utils.ts 51.31% <0.00%> (-28.29%) ⬇️
packages/components/config/src/dateConfig.ts 89.30% <0.00%> (-2.06%) ⬇️
packages/components/icon/src/dependencies.ts 99.05% <0.00%> (-0.07%) ⬇️
packages/components/transfer/src/types.ts 99.57% <0.00%> (-0.01%) ⬇️
packages/components/tree/src/types.ts 99.67% <0.00%> (-0.01%) ⬇️
packages/pro/config/src/types.ts 100.00% <0.00%> (ø)
packages/pro/search/src/types.ts 100.00% <0.00%> (ø)
packages/pro/locales/src/types.ts 100.00% <0.00%> (ø)
packages/pro/tree/src/ProTree.tsx 100.00% <0.00%> (ø)
... and 24 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@typistZxd typistZxd force-pushed the feat-upload-remove-prop-require branch from 943f480 to cbe2769 Compare September 25, 2022 14:51
@typistZxd typistZxd changed the title WIP:Feat upload remove prop require feat(comp:upload): actions and files are optional Sep 27, 2022
@danranVm danranVm merged commit 7e9bee3 into IDuxFE:main Sep 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants