Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(comp:button): style update and group support gap #1235

Merged
merged 1 commit into from
Oct 31, 2022

Conversation

danranVm
Copy link
Member

@danranVm danranVm commented Oct 27, 2022

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our guidelines
  • Tests for the changes have been added/updated or not needed
  • Docs and demo have been added/updated or not needed

What is the current behavior?

What is the new behavior?

  • 重构样式,根据视觉规范进行调整, 同时支持 css variable
  • button group 支持 gap 配置

Other information

@idux-bot
Copy link

idux-bot bot commented Oct 27, 2022

This preview will be available after the AzureCI is passed.

@codecov
Copy link

codecov bot commented Oct 27, 2022

Codecov Report

Merging #1235 (9b5b189) into main (d93b815) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #1235   +/-   ##
=======================================
  Coverage   93.01%   93.01%           
=======================================
  Files         317      317           
  Lines       29136    29140    +4     
  Branches     3307     3309    +2     
=======================================
+ Hits        27101    27105    +4     
  Misses       2035     2035           
Impacted Files Coverage Δ
packages/components/button/src/Button.tsx 98.83% <100.00%> (+0.01%) ⬆️
packages/components/button/src/ButtonGroup.tsx 100.00% <100.00%> (ø)
packages/components/button/src/types.ts 100.00% <100.00%> (ø)
packages/components/tag/src/Tag.tsx 100.00% <100.00%> (ø)
packages/components/textarea/src/Textarea.tsx 100.00% <100.00%> (ø)
packages/components/tree/src/Tree.tsx 95.06% <100.00%> (+0.02%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@danranVm danranVm merged commit 7613c7d into IDuxFE:main Oct 31, 2022
@danranVm danranVm deleted the style-button branch October 31, 2022 02:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant