Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(comp:*): overlay offset with arrow should consider arrow size #1255

Merged
merged 1 commit into from
Nov 7, 2022

Conversation

sallerli1
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our guidelines
  • Tests for the changes have been added/updated or not needed
  • Docs and demo have been added/updated or not needed

What is the current behavior?

overlay 在存在 arrow时,实际计算的offset没有考虑arrow的尺寸

What is the new behavior?

修复以上问题

Other information

@idux-bot
Copy link

idux-bot bot commented Nov 7, 2022

This preview will be available after the AzureCI is passed.

@codecov
Copy link

codecov bot commented Nov 7, 2022

Codecov Report

Merging #1255 (b1d5744) into main (f3aa234) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #1255   +/-   ##
=======================================
  Coverage   93.05%   93.06%           
=======================================
  Files         320      320           
  Lines       29448    29467   +19     
  Branches     3339     3343    +4     
=======================================
+ Hits        27403    27422   +19     
  Misses       2045     2045           
Impacted Files Coverage Δ
...ckages/components/_private/overlay/src/Overlay.tsx 97.52% <100.00%> (+0.25%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@danranVm danranVm merged commit 81802c6 into IDuxFE:main Nov 7, 2022
@sallerli1 sallerli1 deleted the fix-overlay-offset-with-arrow branch February 20, 2023 06:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants