Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cdk:popper): display: none reference is not treat as hidden #1659

Merged
merged 1 commit into from
Aug 21, 2023

Conversation

sallerli1
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our guidelines
  • Tests for the changes have been added/updated or not needed
  • Docs and demo have been added/updated or not needed

What is the new behavior?

为了适应一些refernece是鼠标浮动上去才显示的场景,display: none以及display: contents且第一个元素为display: none的元素,如果祖先节点不存在隐藏的节点,则不应当被视为reference hidden使浮层被隐藏,

Other information

@idux-bot
Copy link

idux-bot bot commented Aug 21, 2023

This preview will be available after the AzureCI is passed.

@codecov
Copy link

codecov bot commented Aug 21, 2023

Codecov Report

Merging #1659 (a8dc6bf) into main (192ca82) will not change coverage.
The diff coverage is n/a.

❗ Current head a8dc6bf differs from pull request most recent head c649c73. Consider uploading reports for the commit c649c73 to get more accurate results

@@           Coverage Diff           @@
##             main    #1659   +/-   ##
=======================================
  Coverage   92.59%   92.59%           
=======================================
  Files         345      345           
  Lines       32285    32285           
  Branches     3685     3685           
=======================================
  Hits        29895    29895           
  Misses       2390     2390           

@sallerli1 sallerli1 merged commit 830be33 into IDuxFE:main Aug 21, 2023
7 checks passed
@sallerli1 sallerli1 deleted the fix-cdk-reference-hidden-contents branch July 4, 2024 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant