Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(pro:search): rest count should hide when no item is overflowed #1736

Merged
merged 1 commit into from
Nov 6, 2023

Conversation

sallerli1
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our guidelines
  • Tests for the changes have been added/updated or not needed
  • Docs and demo have been added/updated or not needed

What is the current behavior?

当没有任何搜索项溢出容器时,异常展示 +0

What is the new behavior?

没有任何搜索项溢出时,不应当展示 rest

Other information

Copy link

idux-bot bot commented Nov 6, 2023

This preview will be available after the AzureCI is passed.

Copy link

codecov bot commented Nov 6, 2023

Codecov Report

Merging #1736 (eb797ba) into main (873d214) will increase coverage by 0.00%.
Report is 1 commits behind head on main.
The diff coverage is 66.66%.

❗ Current head eb797ba differs from pull request most recent head 5ae6772. Consider uploading reports for the commit 5ae6772 to get more accurate results

@@           Coverage Diff           @@
##             main    #1736   +/-   ##
=======================================
  Coverage   92.31%   92.31%           
=======================================
  Files         346      346           
  Lines       32781    32784    +3     
  Branches     3704     3709    +5     
=======================================
+ Hits        30261    30266    +5     
+ Misses       2520     2518    -2     
Files Coverage Δ
packages/components/_private/overflow/src/Item.tsx 100.00% <100.00%> (ø)
packages/components/_private/overflow/src/types.ts 100.00% <100.00%> (ø)
...ages/components/_private/overflow/src/Overflow.tsx 85.04% <83.33%> (+2.47%) ⬆️
packages/pro/search/src/ProSearch.tsx 15.56% <0.00%> (-0.25%) ⬇️

@sallerli1 sallerli1 merged commit a436e92 into IDuxFE:main Nov 6, 2023
7 checks passed
@sallerli1 sallerli1 deleted the fix-pro-search-rest-visiblke branch July 4, 2024 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant