-
Notifications
You must be signed in to change notification settings - Fork 140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(cdk:scroll): optimize virtual scroll render pool resuage #1837
Merged
sallerli1
merged 1 commit into
IDuxFE:next
from
sallerli1:fix-virtual-scroll-pool-resuse
Jan 29, 2024
Merged
fix(cdk:scroll): optimize virtual scroll render pool resuage #1837
sallerli1
merged 1 commit into
IDuxFE:next
from
sallerli1:fix-virtual-scroll-pool-resuse
Jan 29, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This preview will be available after the AzureCI is passed. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## next #1837 +/- ##
==========================================
- Coverage 91.21% 91.21% -0.01%
==========================================
Files 348 348
Lines 34073 34076 +3
Branches 3730 3729 -1
==========================================
+ Hits 31080 31081 +1
- Misses 2993 2995 +2 ☔ View full report in Codecov by Sentry. |
sallerli1
force-pushed
the
fix-virtual-scroll-pool-resuse
branch
from
January 29, 2024 12:45
660e2f9
to
998abea
Compare
sallerli1
added a commit
that referenced
this pull request
Feb 1, 2024
* fix(pro:transfer): maximum recursive updates exceeded under vue 3.4 * feat: dynamic theme with theme tokens is now supported (#1737) BREAKING CHANGE: original css vars and less vars are removed BREAKING CHANGE: original default theme is removed, seer is now default theme BREAKING CHANGE: original style entries is removed, now only index is provided * feat: remove typography support (#1738) BREAKING CHANGE: typography is removed * feat(cdk:theme): add cdk theme support (#1739) * build: update prerelease script * docs(release): publish v2.0.0-beta.0 * docs(release): update changelog * ci: update test * feat: add dark theme (#1751) * feat: add dark theme * build: update eslint and prettier dependencies * docs: add theme documentations (#1754) * docs(release): publish v2.0.0-beta.1 * docs(release): update changelog * fix: style dependencies missing in on-demand import entries (#1755) * feat: add theme entries for on-demand import (#1756) * docs: update docs for v2 (#1757) * fix(comp:checkbox): button theme not registered (#1758) * docs(release): publish v2.0.0-beta.2 * docs(release): update changelog * fix(pro:layout): logo title color theme var reference error (#1759) * feat(comp:table): change rowHeight theme tokens to paddings (#1760) * fix(comp:pagination): change lg size font size to fontSizeSm (#1761) * fix(comp:modal): adjust the icon of the modal that confirm the mode (#1763) * fix(comp:modal): fix adjust modal icon height (#1762) * feat: modify disable color theme tokens (#1764) * feat(comp:theme): root level IxThemeProvider is no longer needed (#1765) * feat(cdk:forms): add `interactions` trigger (#1766) * feat(comp:drawer): distance is configurable and determined by drawer size (#1767) * feat(comp:table): add insetShadow to horizontal overlowed container (#1768) * fix(pro:layout): style error when theme style not injected (#1769) * fix(cdk:forms): interactions trigger dosen't work (#1770) * fix(pro:layout): dark theme overlay menu style error (#1771) * build: update theme doc (#1772) * docs(release): publish v2.0.0-beta.3 * docs(release): update changelog * feat(cdk:scroll): virtual scroll supports horizontal (#1775) BREAKING CHANGE: itemHeight is deprecated, use rowHeight instead BREAKING CHANGE: itemRender is deprecated, use rowRender instead * fix(comp:cascader): the value is incorrect after clicking the clear icon (#1774) * feat(comp:table): add virtualHorizontal support (#1776) * fix(comp:select): selectOptionFontSize theme var reference error (#1777) * docs(release): publish v2.0.0-beta.4 * docs(release): update changelog * feat(comp:tag): support compact group tags (#1779) * fix(comp:popover,tooltip): replace paddings with theme variables (#1780) * fix(comp:table): pagination should hide when data empty (#1782) * fix(comp:head): modify header bar style (#1781) * fix(comp:tree): update tree line style (#1783) * fix(cdk:popper): modify default placement to `bottomStart` (#1785) * feat(comp:table): column align supports cell and title (#1784) * fix(comp:upload): file is not uploaded when maxCount is 1 (#1786) * fix(comp:upload): file remove icon should be 'close' (#1787) * fix(comp:tabs): tabs segment mod nav font-weight should be normal (#1788) * fix(comp): modify offline color token (#1789) * fix(comp:timeline): modify contentMarginBottom to marginSizeLg (#1791) * fix(comp:collapse): modify header font-size to fontSizeHeaderSm (#1790) * fix(comp:tag): modify tag normal bg color (#1792) * fix(pro:search): replace spacing with theme tokens (#1793) * fix(comp:table): table header not visible when width not collected (#1794) * fix(pro:search): container zIndex shouldn't be set when not focused (#1795) * fix(pro:search): searchable fields should keep search text after value change (#1796) * docs: update theme docs (#1797) * fix(comp:table): scroll classes is determined by scroll overflowed (#1798) * fix(comp:tree): virtual treeNode slots not passed (#1799) * build: remove uncessary console statements * fix(comp:tree): virtual treeNode slots not passed * docs(release): publish v2.0.0-beta.5 * docs(release): update changelog * docs(comp:empty): change empty slot demo style (#1803) * fix(comp:header): change bar height (#1804) * docs(comp:table): set table demo head count column align to left (#1805) * docs(comp:modal): set demo margin bottom to 0px (#1806) * docs(comp:table): set table demo operation col gap (#1807) * docs(comp:dropdown): demo icon vertical center (#1810) * fix(comp:alert): change alert icon marigin-right to marginSizeXs(#1802) * fix(comp:collapse): change header prefix margin right to marginSizeMd (#1811) * fix(comp:tag): change tag padding x to 8px, use box-shadow instead of border (#1801) * fix(cdk:popper): arrow size not properly calculated (#1813) * feat(cdk:scroll): add simulated scroll support to VirtualScroll (#1812) * build: fix lint errors (#1816) * feat(pro:search): select field supports caching selected data (#1814) * fix(comp:*): modify all overlay default placement to bottomStart (#1815) * fix(comp:tag): reset bordered style from box-shadow to border (#1817) * fix(pro:search): quick select panel search bar overflows (#1819) * docs(comp): update theme docs (#1820) * fix(comp:select): theme token optionGroupMargin unit error (#1821) * docs(release): publish v2.0.0-beta.6 * docs(release): update changelog * fix(comp:popover): remove content padding top (#1822) * fix(comp:button): button is not vertical center when it has icon (#1830) * fix(comp:cascader): remote search is error (#1832) * fix(comp:select): when input change multiply model input width is error (#1829) * docs(comp:stepper): modify size default value (#1827) * feat(cdk:scroll): virtual scrollTo supports horizontal target (#1833) BREAKING CHANGE: scrollTo option index is deprecated, use rowIndex instead BREAKING CHANGE: scrollTo option offset is deprecated, use verticalOffset instead BREAKING CHANGE: scrollTo option key is deprecated, use rowKey instead BREAKING CHANGE: scrollTo option align is deprecated, use verticalAlign instead * fix(comp:table): inconsecutive fixed columns are not fixed (#1835) * fix(comp:table): virtual table scroll sync should be done by virtual scrollTo API (#1834) * fix(comp:drawer): destroyOnHide drawer doesn't destroy if visible is set false before enter transition (#1836) * fix(pro:table): hovering layout tool trigger shouldn't show resize handle (#1838) * fix(cdk:scroll): optimize virtual scroll render pool resuage (#1837) * fix(comp:popconfirm): change style (#1823) * fix(comp:tree): modify tree line spacing (#1839) * fix(comp:alert,tag): replace rgba bg color with color with no alpha (#1840) mix color with alpha with container bg color to get a bg color with no alpha * style(pro:transfer,tree): modify tree node horizontal padding (#1841) * fix(comp:header): header bar should be aligned top (#1842) * fix(comp:select): search input should be cleared after option selected (#1843) * fix(comp:table): tree table line doesn't appear normally (#1844) * docs: update theme doc (#1845) * docs: update deprecated API list (#1847) * fix(cdk:form,comp:icon): fix suspected memory leak (#1846) --------- Co-authored-by: jing <38604634+threedayAAAAA@users.noreply.github.com> Co-authored-by: danranVm <danranvm@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
What is the current behavior?
虚拟滚动渲染池的复用没有规则,仅仅会从池里面找到第一个可用的元素,在渲染数据整体变更后,重新生成的渲染视图不能保证完全复用上次渲染的dom或组件,即使复用了也不能保证和上次渲染的顺序一致,导致性能问题
What is the new behavior?
在从渲染池中拿元素时,优先获取和当前需要渲染的数据的key相同的渲染池元素,最大可能保证两次渲染的稳定性
Other information