Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(comp:*): overlay border color token is invalid #1924

Merged
merged 1 commit into from
May 20, 2024

Conversation

sallerli1
Copy link
Contributor

border-color: none is invalid,use transparent instead

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our guidelines
  • Tests for the changes have been added/updated or not needed
  • Docs and demo have been added/updated or not needed

What is the current behavior?

overlayBorderColor 主题token 不正确
borderColor 不能是 none,不合法

What is the new behavior?

修改为 transparent

Other information

`border-color: none` is invalid,use `transparent` instead
Copy link

idux-bot bot commented May 20, 2024

This preview will be available after the AzureCI is passed.

Copy link

codecov bot commented May 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.78%. Comparing base (d58039c) to head (4dfb9c3).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1924   +/-   ##
=======================================
  Coverage   90.78%   90.78%           
=======================================
  Files         360      360           
  Lines       35471    35471           
  Branches     2834     2834           
=======================================
  Hits        32203    32203           
  Misses       3268     3268           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sallerli1 sallerli1 merged commit f1ac247 into IDuxFE:main May 20, 2024
9 checks passed
@sallerli1 sallerli1 deleted the fix-overlay-border-color-token branch July 4, 2024 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant