Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(comp:table): selection should not be emptied after dataSource change #1938

Merged
merged 1 commit into from
Jun 11, 2024

Conversation

sallerli1
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our guidelines
  • Tests for the changes have been added/updated or not needed
  • Docs and demo have been added/updated or not needed

What is the current behavior?

表格在dataSource改变后(远程搜索或分页的场景),原本选中的项目被清空了

What is the new behavior?

修改以上问题

Other information

在 useTreeCheckState 中,每当选中的key变化后,缓存当前选中的数据,避免在下次处理选中项时数据不存在

Copy link

idux-bot bot commented Jun 11, 2024

This preview will be available after the AzureCI is passed.

Copy link

codecov bot commented Jun 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.77%. Comparing base (2511d1a) to head (bd150bb).

Current head bd150bb differs from pull request most recent head 7d6c9af

Please upload reports for the commit 7d6c9af to get more accurate results.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1938      +/-   ##
==========================================
- Coverage   90.79%   90.77%   -0.02%     
==========================================
  Files         360      360              
  Lines       35484    35526      +42     
  Branches     2835     2839       +4     
==========================================
+ Hits        32216    32250      +34     
- Misses       3268     3276       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sallerli1 sallerli1 merged commit aa97b68 into IDuxFE:main Jun 11, 2024
3 of 7 checks passed
@sallerli1 sallerli1 deleted the fix-table-selection-cache branch July 4, 2024 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant