Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(comp:table): pagination should render but hide when empty #1940

Merged
merged 1 commit into from
Jun 12, 2024

Conversation

sallerli1
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our guidelines
  • Tests for the changes have been added/updated or not needed
  • Docs and demo have been added/updated or not needed

What is the current behavior?

当数据为空时,默认不渲染分页,导致数据改变后分页组件的事件没有正常触发

What is the new behavior?

修复以上问题

Other information

依然渲染分页,但是通过 v-show 隐藏

Copy link

idux-bot bot commented Jun 12, 2024

This preview will be available after the AzureCI is passed.

Copy link

codecov bot commented Jun 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.71%. Comparing base (403b2ca) to head (59ae445).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1940      +/-   ##
==========================================
- Coverage   90.71%   90.71%   -0.01%     
==========================================
  Files         360      360              
  Lines       35595    35591       -4     
  Branches     2843     2842       -1     
==========================================
- Hits        32291    32287       -4     
  Misses       3304     3304              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sallerli1 sallerli1 merged commit e2f7a65 into IDuxFE:main Jun 12, 2024
9 checks passed
@sallerli1 sallerli1 deleted the fix-table-pagination-empty branch July 4, 2024 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant