Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(comp:*): add overlayTabindex prop for all overlayed controls #1977

Merged
merged 1 commit into from
Jul 30, 2024

Conversation

sallerli1
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our guidelines
  • Tests for the changes have been added/updated or not needed
  • Docs and demo have been added/updated or not needed

What is the current behavior?

What is the new behavior?

  1. controlTrigger, datePicker, timePicker, select, treeSelect, proTagSelect, cascader 组件新增 overlayTabindex 配置
  2. 以上组件,在鼠标mosedown之后,会判断点击到的元素是否可以聚焦,如果不可聚焦,则重置焦点到trigger

Other information

Copy link

idux-bot bot commented Jul 30, 2024

This preview will be available after the AzureCI is passed.

Copy link

codecov bot commented Jul 30, 2024

Codecov Report

Attention: Patch coverage is 68.00000% with 32 lines in your changes missing coverage. Please review.

Project coverage is 90.89%. Comparing base (32ac59c) to head (aea90e6).

Files Patch % Lines
packages/cdk/utils/src/dom.ts 8.69% 21 Missing ⚠️
...ents/control-trigger/src/ControlTriggerOverlay.tsx 70.37% 8 Missing ⚠️
packages/pro/tag-select/src/ProTagSelect.tsx 0.00% 2 Missing ⚠️
...ckages/components/_private/trigger/src/Trigger.tsx 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1977      +/-   ##
==========================================
- Coverage   90.91%   90.89%   -0.03%     
==========================================
  Files         358      358              
  Lines       35771    35819      +48     
  Branches     3898     3901       +3     
==========================================
+ Hits        32522    32557      +35     
- Misses       3249     3262      +13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sallerli1 sallerli1 merged commit 0778970 into IDuxFE:main Jul 30, 2024
7 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant