Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(comp:ixmenu): fix error when initialize settings expandKeys #637

Merged
merged 1 commit into from
Dec 21, 2021

Conversation

typistZxd
Copy link
Member

@typistZxd typistZxd commented Dec 21, 2021

fix #636

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our guidelines
  • Tests for the changes have been added/updated or not needed
  • Docs and demo have been added/updated or not needed

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Component style update
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Application (the showcase website) / infrastructure changes
  • Other... Please describe:

What is the current behavior?

#636

What is the new behavior?

When vertical and horizontal, the initial setting expandedKeys does not expand IxMenuSub

Other information

@idux-bot
Copy link

idux-bot bot commented Dec 21, 2021

This preview will be available after the AzureCI is passed.

@codecov
Copy link

codecov bot commented Dec 21, 2021

Codecov Report

Merging #637 (80965f2) into main (4e446fc) will decrease coverage by 0.05%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #637      +/-   ##
==========================================
- Coverage   83.09%   83.03%   -0.06%     
==========================================
  Files         370      374       +4     
  Lines        9338     9363      +25     
  Branches     2154     2160       +6     
==========================================
+ Hits         7759     7775      +16     
- Misses       1579     1588       +9     
Impacted Files Coverage Δ
.../components/menu/src/children/menu-sub/MenuSub.tsx 96.96% <100.00%> (+3.31%) ⬆️
...ents/menu/src/children/menu-sub/OverlayContent.tsx 6.66% <0.00%> (-73.34%) ⬇️
...ackages/components/message/src/MessageProvider.tsx 96.66% <0.00%> (ø)
...es/components/menu/src/children/menu-sub/Title.tsx 94.11% <0.00%> (ø)
...kages/components/breadcrumb/src/BreadcrumbItem.tsx 100.00% <0.00%> (ø)
packages/components/breadcrumb/src/types.ts 100.00% <0.00%> (ø)
packages/components/breadcrumb/src/token.ts 100.00% <0.00%> (ø)
packages/components/breadcrumb/src/Breadcrumb.tsx 100.00% <0.00%> (ø)
...mponents/notification/src/NotificationProvider.tsx 97.93% <0.00%> (+0.06%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4e446fc...80965f2. Read the comment docs.

@danranVm danranVm merged commit 131d95b into IDuxFE:main Dec 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[comp:IxProLayout] strange behavior when IxProLayout in collapsed mode
2 participants