Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(comp:private/input): add input component #657

Merged
merged 1 commit into from
Dec 23, 2021
Merged

feat(comp:private/input): add input component #657

merged 1 commit into from
Dec 23, 2021

Conversation

danranVm
Copy link
Member

@danranVm danranVm commented Dec 23, 2021

this input is a pure style component

BREAKING CHANGE: IxInput and IxInputNumber rebuild with _private/input

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our guidelines
  • Tests for the changes have been added/updated or not needed
  • Docs and demo have been added/updated or not needed

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Component style update
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Application (the showcase website) / infrastructure changes
  • Other... Please describe:

What is the current behavior?

What is the new behavior?

Other information

@idux-bot
Copy link

idux-bot bot commented Dec 23, 2021

This preview will be available after the AzureCI is passed.

@codecov
Copy link

codecov bot commented Dec 23, 2021

Codecov Report

Merging #657 (f738670) into main (9eced60) will increase coverage by 0.01%.
The diff coverage is 93.66%.

❗ Current head f738670 differs from pull request most recent head ba836f8. Consider uploading reports for the commit ba836f8 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##             main     #657      +/-   ##
==========================================
+ Coverage   83.64%   83.66%   +0.01%     
==========================================
  Files         393      396       +3     
  Lines        9849     9897      +48     
  Branches     2268     2273       +5     
==========================================
+ Hits         8238     8280      +42     
- Misses       1611     1617       +6     
Impacted Files Coverage Δ
packages/components/drawer/src/types.ts 100.00% <ø> (ø)
packages/components/input/index.ts 100.00% <ø> (ø)
packages/components/modal/src/types.ts 100.00% <ø> (ø)
...ages/components/input-number/src/useInputNumber.ts 76.63% <25.00%> (-10.75%) ⬇️
packages/cdk/a11y/src/focusMonitor.ts 85.35% <37.50%> (-0.65%) ⬇️
packages/components/utils/src/useFormElement.ts 95.65% <94.11%> (-4.35%) ⬇️
packages/components/_private/input/index.ts 100.00% <100.00%> (ø)
packages/components/_private/input/src/Input.tsx 100.00% <100.00%> (ø)
packages/components/_private/input/src/types.ts 100.00% <100.00%> (ø)
packages/components/drawer/src/Drawer.tsx 93.24% <100.00%> (+0.09%) ⬆️
... and 18 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9eced60...ba836f8. Read the comment docs.

this input is a pure style component

BREAKING CHANGE: IxInput and IxInputNumber rebuild with _private/input

fix #582

feat(comp:input,input-number): rebuild with _private/input
@danranVm danranVm merged commit efbfda1 into IDuxFE:main Dec 23, 2021
@danranVm danranVm deleted the feat-private-input branch December 23, 2021 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant