Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(comp: space): error color value in style #832

Merged
merged 1 commit into from
Apr 6, 2022

Conversation

liuzaijiang
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our guidelines
  • Tests for the changes have been added/updated or not needed
  • Docs and demo have been added/updated or not needed

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Component style update
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Application (the showcase website) / infrastructure changes
  • Other... Please describe:

What is the current behavior?

     <ix-menu
        v-model:selectedKeys="selectedKeys"
        v-model:expandedKeys="expandedKeys"
        :dataSource="dataSource"
        mode="inline"
      >
        <template #label="item">
          <router-link :to="item.key">
            <ix-space>
              <span>{{ item.label }}</span>
            </ix-space>
          </router-link>
        </template>
      </ix-menu>

由于ix-space给了固定颜色,导致导航被选中时,颜色文字颜色无法根据导航的颜色改变,应该设置为inherit,继承父组件的color值

What is the new behavior?

Other information

@idux-bot
Copy link

idux-bot bot commented Apr 2, 2022

This preview will be available after the AzureCI is passed.

@codecov
Copy link

codecov bot commented Apr 2, 2022

Codecov Report

Merging #832 (a2bbd13) into main (74fb409) will decrease coverage by 0.06%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #832      +/-   ##
==========================================
- Coverage   85.70%   85.64%   -0.07%     
==========================================
  Files         509      505       -4     
  Lines       13127    12952     -175     
  Branches     3181     2825     -356     
==========================================
- Hits        11251    11093     -158     
+ Misses       1875     1858      -17     
  Partials        1        1              
Impacted Files Coverage Δ
packages/components/select/src/Select.tsx 78.26% <0.00%> (-15.49%) ⬇️
...ponents/select/src/composables/useSelectedState.ts 90.00% <0.00%> (-0.25%) ⬇️
...ts/tree-select/src/composables/useSelectedState.ts 95.23% <0.00%> (-0.22%) ⬇️
packages/cdk/utils/src/props.ts 77.41% <0.00%> (ø)
packages/components/select/src/token.ts 100.00% <0.00%> (ø)
packages/components/select/src/types.ts 100.00% <0.00%> (ø)
packages/components/tree-select/src/token.ts 100.00% <0.00%> (ø)
packages/components/tree-select/src/types.ts 66.66% <0.00%> (ø)
packages/components/_private/mask/src/Mask.tsx 100.00% <0.00%> (ø)
packages/components/_private/empty/src/Empty.tsx 100.00% <0.00%> (ø)
... and 37 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 74fb409...a2bbd13. Read the comment docs.

@danranVm danranVm merged commit 052aefe into IDuxFE:main Apr 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants