Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(comp: all): add seer theme #850

Merged
merged 1 commit into from
Apr 19, 2022
Merged

Conversation

liuzaijiang
Copy link
Contributor

@liuzaijiang liuzaijiang commented Apr 15, 2022

BREAKING CHANGE:

  • all components less variables has a little change (pro-layout all less variables change)
  • modal and drawer head size is changed to md by default
  • back-top icon name is changed to arrow-up by default
  • card add shadow props, default value is true
  • pagination pageSizes locale change

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our guidelines
  • Tests for the changes have been added/updated or not needed
  • Docs and demo have been added/updated or not needed

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Component style update
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Application (the showcase website) / infrastructure changes
  • Other... Please describe:

What is the current behavior?

What is the new behavior?

Other information

@idux-bot
Copy link

idux-bot bot commented Apr 15, 2022

This preview will be available after the AzureCI is passed.

@liuzaijiang liuzaijiang changed the title feat(comp: all): add seer themes feat(comp: all): add seer theme Apr 15, 2022
@liuzaijiang liuzaijiang changed the title feat(comp: all): add seer theme [wip]feat(comp: all): add seer theme Apr 15, 2022
@codecov
Copy link

codecov bot commented Apr 15, 2022

Codecov Report

Merging #850 (9db19d6) into main (24f173e) will increase coverage by 0.00%.
The diff coverage is 97.93%.

@@           Coverage Diff           @@
##             main     #850   +/-   ##
=======================================
  Coverage   93.65%   93.65%           
=======================================
  Files         647      647           
  Lines       62759    62818   +59     
  Branches     7571     7582   +11     
=======================================
+ Hits        58776    58833   +57     
- Misses       3983     3985    +2     
Impacted Files Coverage Δ
packages/components/modal/src/ModalWrapper.tsx 81.04% <88.23%> (+0.08%) ⬆️
...ckages/components/_private/overlay/src/Overlay.tsx 97.05% <100.00%> (+0.01%) ⬆️
...ages/components/_private/selector/src/Selector.tsx 99.14% <100.00%> (+<0.01%) ⬆️
packages/components/back-top/src/BackTop.tsx 100.00% <100.00%> (ø)
packages/components/card/__tests__/card.spec.ts 100.00% <100.00%> (ø)
packages/components/card/src/Card.tsx 99.24% <100.00%> (+<0.01%) ⬆️
packages/components/card/src/types.ts 100.00% <100.00%> (ø)
...ackages/components/drawer/__tests__/drawer.spec.ts 100.00% <100.00%> (ø)
packages/components/drawer/src/DrawerWrapper.tsx 83.48% <100.00%> (+0.15%) ⬆️
packages/components/locales/src/langs/en-US.ts 100.00% <100.00%> (ø)
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 24f173e...9db19d6. Read the comment docs.

@liuzaijiang liuzaijiang changed the title [wip]feat(comp: all): add seer theme feat(comp: all): add seer theme Apr 18, 2022
@liuzaijiang liuzaijiang force-pushed the theme-seer-lzj branch 2 times, most recently from ca7a2e5 to 1687f9d Compare April 18, 2022 11:29
@danranVm danranVm merged commit 789a266 into IDuxFE:main Apr 19, 2022
sallerli1 pushed a commit to sallerli1/idux that referenced this pull request Apr 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants