Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(comp: table): add customAdditional to support cosutom row and cell #866

Merged
merged 1 commit into from
Apr 28, 2022

Conversation

danranVm
Copy link
Member

BREAKING CHANGE: tags was deprecated, please use customAdditional instead

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our guidelines
  • Tests for the changes have been added/updated or not needed
  • Docs and demo have been added/updated or not needed

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Component style update
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Application (the showcase website) / infrastructure changes
  • Other... Please describe:

What is the current behavior?

What is the new behavior?

Other information

@idux-bot
Copy link

idux-bot bot commented Apr 27, 2022

This preview will be available after the AzureCI is passed.

BREAKING CHANGE: `tags`, `rowClassName` and `column.additional` are deprecated, please use `customAdditional` instead
@codecov
Copy link

codecov bot commented Apr 28, 2022

Codecov Report

Merging #866 (ecfb736) into main (07475d2) will decrease coverage by 0.00%.
The diff coverage is 97.40%.

❗ Current head ecfb736 differs from pull request most recent head d3a7b2a. Consider uploading reports for the commit d3a7b2a to get more accurate results

@@            Coverage Diff             @@
##             main     #866      +/-   ##
==========================================
- Coverage   93.50%   93.50%   -0.01%     
==========================================
  Files         657      656       -1     
  Lines       64519    64497      -22     
  Branches     7854     7842      -12     
==========================================
- Hits        60331    60307      -24     
- Misses       4188     4190       +2     
Impacted Files Coverage Δ
...ackages/components/table/src/main/StickyScroll.tsx 16.76% <0.00%> (-0.10%) ⬇️
packages/components/table/src/main/MainTable.tsx 76.52% <71.42%> (-0.21%) ⬇️
packages/components/table/src/main/body/Body.tsx 95.45% <85.71%> (ø)
packages/components/config/src/defaultConfig.ts 100.00% <100.00%> (ø)
packages/components/config/src/types.ts 100.00% <100.00%> (ø)
...kages/components/pagination/src/contents/Sizes.tsx 100.00% <100.00%> (ø)
packages/components/table/index.ts 97.36% <100.00%> (ø)
packages/components/table/src/Table.tsx 100.00% <100.00%> (ø)
.../components/table/src/composables/useDataSource.ts 80.95% <100.00%> (+0.11%) ⬆️
...s/components/table/src/composables/useGetRowKey.ts 94.44% <100.00%> (+0.32%) ⬆️
... and 12 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 07475d2...d3a7b2a. Read the comment docs.

@danranVm danranVm merged commit e79b55b into IDuxFE:main Apr 28, 2022
@danranVm danranVm deleted the refactor-table branch April 28, 2022 01:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant