Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(comp: select): add customAdditional and getKey #868

Merged
merged 1 commit into from
Apr 28, 2022

Conversation

danranVm
Copy link
Member

BREAKING CHANGE: compareFn was removed. target was deprecated, please use overlayContainer
instead. valueKey was deprecated, please use getKey instead. dataSource.additional was
deprecated, please use customAdditional instead.

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our guidelines
  • Tests for the changes have been added/updated or not needed
  • Docs and demo have been added/updated or not needed

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Component style update
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Application (the showcase website) / infrastructure changes
  • Other... Please describe:

What is the current behavior?

What is the new behavior?

Other information

@idux-bot
Copy link

idux-bot bot commented Apr 28, 2022

This preview will be available after the AzureCI is passed.

@codecov
Copy link

codecov bot commented Apr 28, 2022

Codecov Report

Merging #868 (063d39b) into main (e79b55b) will increase coverage by 0.00%.
The diff coverage is 97.60%.

❗ Current head 063d39b differs from pull request most recent head cc4a574. Consider uploading reports for the commit cc4a574 to get more accurate results

@@           Coverage Diff           @@
##             main     #868   +/-   ##
=======================================
  Coverage   93.49%   93.50%           
=======================================
  Files         656      657    +1     
  Lines       64497    64592   +95     
  Branches     7840     7845    +5     
=======================================
+ Hits        60302    60394   +92     
- Misses       4195     4198    +3     
Impacted Files Coverage Δ
...ponents/select/src/composables/useSelectedState.ts 89.89% <83.33%> (ø)
...mponents/select/src/composables/useGetOptionKey.ts 91.89% <91.89%> (ø)
packages/components/config/src/defaultConfig.ts 100.00% <100.00%> (ø)
packages/components/config/src/types.ts 100.00% <100.00%> (ø)
...kages/components/pagination/src/contents/Sizes.tsx 100.00% <100.00%> (ø)
...ackages/components/select/__tests__/select.spec.ts 100.00% <100.00%> (ø)
packages/components/select/src/Select.tsx 93.10% <100.00%> (+0.40%) ⬆️
...omponents/select/src/composables/useActiveState.ts 89.88% <100.00%> (ø)
...es/components/select/src/composables/useOptions.ts 97.63% <100.00%> (-0.09%) ⬇️
packages/components/select/src/content/Content.tsx 77.88% <100.00%> (ø)
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e79b55b...cc4a574. Read the comment docs.

BREAKING CHANGE: `compareFn` was removed. `target` was deprecated, please use `overlayContainer`
instead. `valueKey` was deprecated, please use `getKey` instead. `dataSource.additional` was
deprecated, please use `customAdditional` instead.
@danranVm danranVm merged commit d10f5e0 into IDuxFE:main Apr 28, 2022
@danranVm danranVm deleted the refactor-select branch April 28, 2022 07:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant