Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(comp: pagination): Showquickjumper does not work in simple mode #928

Merged
merged 1 commit into from
May 25, 2022

Conversation

liuzaijiang
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our guidelines
  • Tests for the changes have been added/updated or not needed
  • Docs and demo have been added/updated or not needed

What is the current behavior?

默认情况下Showquickjumper为false,对simple不生效

<IxPagination :total="500" simple />

image

What is the new behavior?

image

Other information

@idux-bot
Copy link

idux-bot bot commented May 25, 2022

This preview will be available after the AzureCI is passed.

@codecov
Copy link

codecov bot commented May 25, 2022

Codecov Report

Merging #928 (06535c1) into main (0967d4c) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #928      +/-   ##
==========================================
- Coverage   93.38%   93.38%   -0.01%     
==========================================
  Files         679      679              
  Lines       66644    66670      +26     
  Branches     5881     5888       +7     
==========================================
+ Hits        62238    62261      +23     
- Misses       4406     4409       +3     
Impacted Files Coverage Δ
...components/pagination/__tests__/pagination.spec.ts 100.00% <100.00%> (ø)
packages/components/pagination/src/Pagination.tsx 100.00% <100.00%> (ø)
packages/components/table/src/utils/index.ts 85.96% <0.00%> (-7.14%) ⬇️
packages/components/table/index.ts 95.23% <0.00%> (-2.14%) ⬇️
...ges/components/tree/src/composables/useDragDrop.ts 36.24% <0.00%> (-0.36%) ⬇️
...s/components/tree/src/composables/useExpandable.ts 97.05% <0.00%> (-0.05%) ⬇️
packages/components/table/src/types.ts 100.00% <0.00%> (ø)
...ges/components/table/src/composables/useColumns.ts 74.00% <0.00%> (+0.18%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0967d4c...06535c1. Read the comment docs.

@danranVm
Copy link
Member

@liuzaijiang test 挂掉了

@danranVm danranVm merged commit 2955e7f into IDuxFE:main May 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants