Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(comp:tree*): add draggableIcon prop #948

Merged
merged 1 commit into from
Jun 11, 2022

Conversation

liuzaijiang
Copy link
Contributor

@liuzaijiang liuzaijiang commented Jun 10, 2022

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our guidelines
  • Tests for the changes have been added/updated or not needed
  • Docs and demo have been added/updated or not needed

What is the current behavior?

What is the new behavior?

image

image

Other information

@idux-bot
Copy link

idux-bot bot commented Jun 10, 2022

This preview will be available after the AzureCI is passed.

@codecov
Copy link

codecov bot commented Jun 10, 2022

Codecov Report

Merging #948 (8078dd3) into main (c27831d) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head 8078dd3 differs from pull request most recent head f22b0aa. Consider uploading reports for the commit f22b0aa to get more accurate results

@@           Coverage Diff           @@
##             main     #948   +/-   ##
=======================================
  Coverage   92.76%   92.77%           
=======================================
  Files         692      692           
  Lines       67697    67787   +90     
  Branches     7920     7928    +8     
=======================================
+ Hits        62798    62888   +90     
  Misses       4899     4899           
Impacted Files Coverage Δ
packages/components/config/src/defaultConfig.ts 100.00% <100.00%> (ø)
packages/components/config/src/types.ts 100.00% <100.00%> (ø)
packages/components/icon/src/dependencies.ts 99.01% <100.00%> (+0.01%) ⬆️
...ges/components/tree-select/src/content/Content.tsx 90.03% <100.00%> (+0.12%) ⬆️
packages/components/tree-select/src/types.ts 99.37% <100.00%> (+<0.01%) ⬆️
packages/components/tree/__tests__/tree.spec.ts 100.00% <100.00%> (ø)
packages/components/tree/src/Tree.tsx 98.04% <100.00%> (ø)
...ges/components/tree/src/composables/useDragDrop.ts 38.65% <100.00%> (+2.41%) ⬆️
packages/components/tree/src/node/TreeNode.tsx 85.95% <100.00%> (+0.74%) ⬆️
packages/components/tree/src/types.ts 99.48% <100.00%> (+<0.01%) ⬆️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c27831d...f22b0aa. Read the comment docs.

Copy link
Member

@danranVm danranVm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

判断第一层,有没有children, 如果有,就需要 expanded-icon-noop 占位
判断是否开启 draggable, 如果开启,就需要 draggable-icon-noop 占位

image

image

@danranVm danranVm merged commit 28b7031 into IDuxFE:main Jun 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants