-
Notifications
You must be signed in to change notification settings - Fork 140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(comp:date-picker): add DatePickerPanel & DateRangePickerPanel #964
feat(comp:date-picker): add DatePickerPanel & DateRangePickerPanel #964
Conversation
This preview will be available after the AzureCI is passed. |
Codecov Report
@@ Coverage Diff @@
## main #964 +/- ##
==========================================
- Coverage 92.67% 92.66% -0.01%
==========================================
Files 706 709 +3
Lines 69123 69320 +197
Branches 8064 8088 +24
==========================================
+ Hits 64058 64236 +178
- Misses 5065 5084 +19
Continue to review full report at Codecov.
|
ef79ff0
to
01c5bae
Compare
visiblePanel: [String, Boolean] as PropType<'datePanel' | 'timePanel'>, | ||
|
||
onChange: [Function, Array] as PropType<MaybeArray<(value: Date | undefined) => void>>, | ||
'onUpdate:activeDate': [Function, Array] as PropType<MaybeArray<(date: Date | undefined) => void>>, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
要么这里改成 onUpdate:activeValue, 要么上面的 activeValue 改成 activeDate ?
type: Object as PropType<TimePanelOptions>, | ||
default: () => ({}), | ||
}, | ||
visiblePanel: [String, Boolean] as PropType<'datePanel' | 'timePanel'>, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
visiblePanel: [String, Boolean] as PropType<'datePanel' | 'timePanel'>, | |
visible: [String, Boolean] as PropType<'date' | 'time' | ‘boolean’>, |
cellTooltip: Function as PropType<(cell: { value: Date; disabled: boolean }) => string | void>, | ||
disabledDate: Function as PropType<(date: Date) => boolean>, | ||
value: Date as PropType<Date>, | ||
defaultOpenValue: Date as PropType<Date>, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
对于 panel 来说,这个 API 名字是不是得改下?
这个 API 现在看起来有点多余,群里问问有人用过这个 API 不?没人用就干掉?
> | ||
export type DatePickerPanelInstance = InstanceType<DefineComponent<DatePickerPanelProps>> | ||
|
||
export const dateRangePickerPanelProps = { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
跟上面的都是一样的问题。
import { dateRangePickerPanelProps } from '../types' | ||
|
||
export default defineComponent({ | ||
name: 'IxDateRangePickerPanel', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
name: 'IxDateRangePickerPanel', | |
name: 'IxDateRangePanel', |
import { applyDateTime } from '../utils' | ||
|
||
export default defineComponent({ | ||
name: 'IxDatePickerPanel', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
name: 'IxDatePickerPanel', | |
name: 'IxDatePanel', |
packages/components/index.ts
Outdated
import { | ||
IxDatePicker, | ||
IxDatePickerPanel, | ||
IxDateRangePicker, | ||
IxDateRangePickerPanel, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
import { | |
IxDatePicker, | |
IxDatePickerPanel, | |
IxDateRangePicker, | |
IxDateRangePickerPanel, | |
import { | |
IxDatePicker, | |
IxDatePanel, | |
IxDateRangePicker, | |
IxDateRangePanel, |
3ed8a44
to
90a5d7e
Compare
90a5d7e
to
04a7c69
Compare
04a7c69
to
dcaf52c
Compare
PR Checklist
Please check if your PR fulfills the following requirements:
What is the current behavior?
What is the new behavior?
抽离日期面板以及日期范围面板 作为 IxDatePickerPanel 、IxDateRangePickerPanel 暴露
Other information
更新部分文档中的样式变量