feat(comp:date-picker): add DatePickerPanel & DateRangePickerPanel #964
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This preview will be available after the AzureCI is passed. |
Codecov Report
@@ Coverage Diff @@
## main #964 +/- ##
==========================================
- Coverage 92.67% 92.66% -0.01%
==========================================
Files 706 709 +3
Lines 69123 69320 +197
Branches 8064 8088 +24
==========================================
+ Hits 64058 64236 +178
- Misses 5065 5084 +19
Continue to review full report at Codecov.
|
sallerli1
changed the title
sallerli1
force-pushed
the
feat-extract-data-panel-saller
branch
2 times, most recently
from
ef79ff0
to
01c5bae
Compare
danranVm
requested changes
Jun 24, 2022
| visiblePanel: [String, Boolean] as PropType<'datePanel' | 'timePanel'>, | ||
|
|
||
| onChange: [Function, Array] as PropType<MaybeArray<(value: Date | undefined) => void>>, | ||
| 'onUpdate:activeDate': [Function, Array] as PropType<MaybeArray<(date: Date | undefined) => void>>, |
There was a problem hiding this comment.
要么这里改成 onUpdate:activeValue, 要么上面的 activeValue 改成 activeDate ？
| type: Object as PropType<TimePanelOptions>, | ||
| default: () => ({}), | ||
| }, | ||
| visiblePanel: [String, Boolean] as PropType<'datePanel' | 'timePanel'>, |
There was a problem hiding this comment.
Suggested change
| visiblePanel: [String, Boolean] as PropType<'datePanel' | 'timePanel'>, | |
| visible: [String, Boolean] as PropType<'date' | 'time' | ‘boolean’>, |
| cellTooltip: Function as PropType<(cell: { value: Date; disabled: boolean }) => string | void>, | ||
| disabledDate: Function as PropType<(date: Date) => boolean>, | ||
| value: Date as PropType<Date>, | ||
| defaultOpenValue: Date as PropType<Date>, |
There was a problem hiding this comment.
对于 panel 来说，这个 API 名字是不是得改下？
这个 API 现在看起来有点多余，群里问问有人用过这个 API 不？没人用就干掉？
| > | ||
| export type DatePickerPanelInstance = InstanceType<DefineComponent<DatePickerPanelProps>> | ||
|
|
||
| export const dateRangePickerPanelProps = { |
| import { dateRangePickerPanelProps } from '../types' | ||
|
|
||
| export default defineComponent({ | ||
| name: 'IxDateRangePickerPanel', |
There was a problem hiding this comment.
Suggested change
| name: 'IxDateRangePickerPanel', | |
| name: 'IxDateRangePanel', |
| import { applyDateTime } from '../utils' | ||
|
|
||
| export default defineComponent({ | ||
| name: 'IxDatePickerPanel', |
There was a problem hiding this comment.
Suggested change
| name: 'IxDatePickerPanel', | |
| name: 'IxDatePanel', |
packages/components/index.ts
Outdated
Comment on lines
24
to
28
| import { | ||
| IxDatePicker, | ||
| IxDatePickerPanel, | ||
| IxDateRangePicker, | ||
| IxDateRangePickerPanel, |
There was a problem hiding this comment.
Suggested change
| import { | |
| IxDatePicker, | |
| IxDatePickerPanel, | |
| IxDateRangePicker, | |
| IxDateRangePickerPanel, | |
| import { | |
| IxDatePicker, | |
| IxDatePanel, | |
| IxDateRangePicker, | |
| IxDateRangePanel, |
sallerli1
force-pushed
the
feat-extract-data-panel-saller
branch
2 times, most recently
from
3ed8a44
to
90a5d7e
Compare
danranVm
approved these changes
Jun 29, 2022
sallerli1
force-pushed
the
feat-extract-data-panel-saller
branch
from
90a5d7e
to
04a7c69
Compare
sallerli1
force-pushed
the
feat-extract-data-panel-saller
branch
from
04a7c69
to
dcaf52c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
What is the current behavior?
What is the new behavior?
抽离日期面板以及日期范围面板 作为 IxDatePickerPanel 、IxDateRangePickerPanel 暴露
Other information
更新部分文档中的样式变量