You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The current implementation is using PyYAML, which is is no longer maintained (although it has recently had some activity, but it still seems that it do not have a development group).
The PyYAML implementation is wrapping a C implementation and hence it can lead to issues when installing, which I have seen for some Windows users.
I would suggest switching to ruamel.yaml instead. It is a pure python version and hence do not suffer from the same installation issue. As an added benefit it can also do round-trip conversion which means it will preserve comments and white space. It can also use the PyYAML parser that is faster by changing the parser type (e.g. typ="safe").
As the implementation aims to make a default parser I would suggest the following for the yaml settings for the yaml object:
Love all of the ideas you have been posting here, @kenloen . For this one and others like it, I would suggest just moving straight to a PR as I don't imagine anyone would object.
I know that some of the issues that I have posted might seem small, and that creating these issues might take the same amount of time as just creating a PR and doing it my self. But as always with code development, the time that one expect it will take is always much more than what it ends up taking.
Furthermore, the purpose of all these issues is to map all the things that should be added/changed so that we can priotize which things are more urgent.
I am sorry if this comes across as me trying to not do it my self. My aim was to first map some of the issues and I hope that would motivate others to also add issues for some of the things they would like to add or change.
The current implementation is using
PyYAML
, which is is no longer maintained (although it has recently had some activity, but it still seems that it do not have a development group).The PyYAML implementation is wrapping a C implementation and hence it can lead to issues when installing, which I have seen for some Windows users.
I would suggest switching to
ruamel.yaml
instead. It is a pure python version and hence do not suffer from the same installation issue. As an added benefit it can also do round-trip conversion which means it will preserve comments and white space. It can also use the PyYAML parser that is faster by changing the parser type (e.g.typ="safe"
).As the implementation aims to make a default parser I would suggest the following for the yaml settings for the yaml object:
The text was updated successfully, but these errors were encountered: