-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Recipe #283: Missing images in a sequence #120
Comments
Suggestion in the implementation notes: instead of |
@julsraemy I like this. |
I also think its a good suggestion but maybe wait to make the change until after the TRC review period. |
A tiny detail in Implementation notes: I do not see why |
I would support changing the reason for the empty |
(Usual comment that I upvoted my own recipe) |
Issue 120 (Recipe #283: Missing images in a sequence)+1: 19 [akrishnan15 cubap danieltbrennan dlpierce glenrobson hadro ioanrichards irv julsraemy kirschbombe ktamaral markpbaggett nfreire regisrob robcast tpendragon triplingual tristanr-cogapp rentonsa] Result: 19 / 19 = 1.00Super majority is in favor, issue is approved |
Changes to implement from |
Ach, @cubap I neglected to credit you in the commit for your change. Apologies! |
Links
Background and Summary
This recipe covers a common use case with IIIF Manifests where the item that is being digitised has pages that haven't been scanned. This could be due to a mistake during scanning or the source image could be blank or lost. This recipe covers the recommend method for identifing pages which are missing and can help with showing paginated pages in a viewer.
Voting and changes
We welcome comments on the recipe and as well as voting +1, confused face or -1 feel free to add comments to this issue. If this issue is approved then the author will take account of the comments before we merge the branch in to the master cookbook branch.
If the recipe is rejected by the TRC then we will make the changes requested and resubmit it to a future TRC meeting. If you feel that your comments are substantial enough that the recipe should be looked at again by the TRC after the changes have been made please vote -1 (thumbs down). A confused face is treated as abstaining.
Changes to the recipe will only be made after the TRC voting process has concluded.
The text was updated successfully, but these errors were encountered: