You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
In binding_map.cpp, when calling intersect() or contains() on StructureValue s and AtomValues, we only do exact matching of atoms, or, in the case of floats, the match is calculated with Utils::Equal(). This should be changed to allow the matching of objects, especially for StructureValues. This would allow for user-defined equals-operators, allowing for more complex matching. For example, we could define angle as its own class and use user-defined equals-operators to check for 2*pi angle difference. Or use more complex structures for direct matching.
The code would need to be changed to utilize user-defined operators in the following three code segments.
In
binding_map.cpp
, when callingintersect()
orcontains()
onStructureValue
s andAtomValue
s, we only do exact matching of atoms, or, in the case of floats, the match is calculated withUtils::Equal()
. This should be changed to allow the matching of objects, especially forStructureValue
s. This would allow for user-defined equals-operators, allowing for more complex matching. For example, we could defineangle
as its own class and use user-defined equals-operators to check for 2*pi angle difference. Or use more complex structures for direct matching.The code would need to be changed to utilize user-defined operators in the following three code segments.
AERA/r_exec/binding_map.cpp
Lines 204 to 213 in f774c52
AERA/r_exec/binding_map.cpp
Lines 293 to 313 in f774c52
AERA/r_exec/binding_map.cpp
Lines 720 to 729 in f774c52
The text was updated successfully, but these errors were encountered: