Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How to identify the target subset in subset membership change operations? #41

Closed
gouttegd opened this issue Jun 24, 2023 · 1 comment
Closed

Comments

@gouttegd
Copy link

For the AddNodeToSubset and RemoveNodeToSubset changes, the subset the node should be added to/removed from is supposed to be represented by the in_subset slot of a AddToSubset or RemoveFromSubset mixin. That slot expects a OntologySubset, defined in ontology_model.yaml.

But OntologySubset has seemingly no slots at all (either directly or inherited from OntologyElement), so how one is supposed to know which subset the change is about?

Shouldn’t OntologySubset have a id slot to identify the subset?

@gouttegd
Copy link
Author

gouttegd commented Mar 8, 2024

Closing as this has been fixed by #62 (by making OntologySubset a type of Node, therefore giving it an ID).

@gouttegd gouttegd closed this as completed Mar 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant