Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

change: spoon-maven-plugin should use the fullclasspath by default #3345

Open
monperrus opened this issue Apr 24, 2020 · 1 comment
Open

change: spoon-maven-plugin should use the fullclasspath by default #3345

monperrus opened this issue Apr 24, 2020 · 1 comment

Comments

@monperrus
Copy link
Collaborator

@vmassol suggests that spoon-maven-plugin should use the fullclasspath by default because a Maven project has the correct classpath by construction.

WDYT?
@monperrus monperrus mentioned this issue Apr 24, 2020
Merged
@MartinWitt
Copy link
Collaborator

MartinWitt commented Apr 25, 2020 •
edited
Loading

First: the breaker for this is fixed now. (see SpoonLabs/spoon-maven-plugin#68)

I would be complete in favor for this:

  • the setting: <noClasspath>false</noClasspath> is overcomplex. (negating a negation)
  • a maven project should always have all dependencies

@monperrus monperrus changed the title change: spoon-maven-plugin should use the fullclasspath by default change: spoon-maven-plugin should use the fullclasspath by default (remove srcFolder) Apr 30, 2020
@monperrus monperrus changed the title change: spoon-maven-plugin should use the fullclasspath by default (remove srcFolder) change: spoon-maven-plugin should use the fullclasspath by default May 11, 2020
@MartinWitt MartinWitt mentioned this issue May 20, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@monperrus @MartinWitt