Prevent logging?

[gchaperon]

Is it currently possible to prevent logging completely?

I am looking at the source and it seems to me that it is not possible, since only valid names defined in spoon.support.Level are allowd here

spoon/src/main/java/spoon/support/StandardEnvironment.java

Line 190 in fecec81

private Level toLevel(String level) {

Please let me know if I have overlooked something and it is actually possible.

If it is not possible, how would you feel about adding OFF(0) to Level. Would that allow to turn logging completely off?

Best,
Gabriel.

[slarse]

Hi @gchaperon,

I see no reason not to offer that. I'd say it's rather unexpected to find that you can set logging levels, but none of them allow you to disable logging entirely.

Care to do a PR? :)

[monperrus]

In theory, the logging can be entirely disabled via slf4j (by configuring logback in logback.xml)

[slarse]

In theory, the logging can be entirely disabled via slf4j (by configuring logback in logback.xml)

Ah, yes, that is true. But as we have an API for setting the logging level, wouldn't it also make sense to add an OFF level? It wouldn't be much effort at all, just adding the level to Level and then patching up the switch statement that deals with logging in StandardEnvironment.

[monperrus]

But as we have an API for setting the logging level, wouldn't it also make sense to add an OFF level?

yes it would!

[slarse]

yes it would!

Let's put it on the TODO list then :)

@gchaperon Would you like to try your hand at a PR for this feature?

[gchaperon]

hi, ya sure, i can try
looking more in detail I have a question.
i see that this method is only used internally, so the setLevel config on StandardEnvironment only applies to the logging produced by that class. I think this is somewhat confusing for the user, shouldn't be all logging managed by slf4j?