Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CtElements.equals() returns true for elements which are not equal #602

Closed
leventov opened this issue Apr 19, 2016 · 2 comments
Closed

CtElements.equals() returns true for elements which are not equal #602

leventov opened this issue Apr 19, 2016 · 2 comments

Comments

@leventov
Copy link
Contributor

The new HashCodeVisitor presented here: #601 (comment) produces different hash codes for ctElements that are considered equal by current equals() implementation. I can hardly imagine how the referenced HashCodeVisitor may produce different hash codes for elements that are actually equal.
@monperrus
Copy link
Collaborator

The HashCodeVisitor you propose is too specific. Could you give a precise example of elements that should be considered equal?

@monperrus
Copy link
Collaborator

closing this issue, see #674

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@leventov @monperrus