Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GE-core_Borehole.boreholeLength_no nilReason attribute provided #121

Closed
JohannaOtt opened this issue Mar 22, 2024 · 3 comments · Fixed by #122
Closed

GE-core_Borehole.boreholeLength_no nilReason attribute provided #121

JohannaOtt opened this issue Mar 22, 2024 · 3 comments · Fixed by #122
Labels
for JRC The change proposal is to be implemented by the JRC. non-breaking change The change proposal does not prevent backward compatibility of the schema
Milestone

Comments

@JohannaOtt
Copy link

Hi,

Borehole.boreholeLength is using the stereotype voidable according to the implementing rules and the UML model.
In the xsd, it is defined using the swe:QuantityPropertyType and no additional attributes which leads to the fact that no nilReason attribute can be provided for Borehole.boreholeLength.
Is there a reason not to use a type extending the swe:QuantityPropertyType with an additional nilReason attribute for the boreholeLength element?

Thank you and all the best

Johanna

@fabiovinci
Copy link
Collaborator

Dear @JohannaOtt,

no, there is not, it seems that the Borehole.boreholeLength attribute is not encoded correctly.
I will move the issue to the schema repository since the encoding should be fixed.

@fabiovinci fabiovinci transferred this issue from INSPIRE-MIF/helpdesk Mar 25, 2024
@fabiovinci
Copy link
Collaborator

The current encoding:

<element name="boreholeLength" nillable="true" type="swe:QuantityPropertyType">
   <annotation>
      <documentation>-- Definition --The distance along a borehole.-- Description --This
         will be determined by the data provider (ie, "length" can have different sources,
         like drillers measurement, loggers measurement, survey). 
     </documentation>
   </annotation>
</element>

should be replaced by the following:

<element name="boreholeLength" nillable="true">
  <annotation>
    <documentation>-- Definition -- The distance along a borehole. -- Description -- This
      will be determined by the data provider (ie, "length" can have different sources,
      like drillers measurement, loggers measurement, survey).</documentation>
  </annotation>
  <complexType>
    <complexContent>
      <extension base="gml:AbstractMemberType">
        <sequence>
          <element ref="swe:Quantity"/>
        </sequence>
        <attribute name="nilReason" type="gml:NilReasonType"/>
      </extension>
    </complexContent>
  </complexType>
</element>

As shown in the figure below, the new encoding (on the left side) allows the provision of the nilReason.

Diff_encodings

@fabiovinci fabiovinci added the for JRC The change proposal is to be implemented by the JRC. label Mar 25, 2024
@fabiovinci fabiovinci added this to the 2024.2 milestone Mar 25, 2024
@fabiovinci fabiovinci linked a pull request Mar 25, 2024 that will close this issue
@JohannaOtt
Copy link
Author

@fabiovinci Thanks for the quick check and fix!

@fabiovinci fabiovinci added the non-breaking change The change proposal does not prevent backward compatibility of the schema label Jul 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
for JRC The change proposal is to be implemented by the JRC. non-breaking change The change proposal does not prevent backward compatibility of the schema
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants