Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Statistical Units Vector - geometry test for GM_MultiSurface is too strict #714

Closed
ulbrichtd opened this issue Feb 24, 2022 · 6 comments
Closed
Labels
deployed in reference validator Solution deployed in production non-breaking change The change makes tests less restrictive and it has no impact on resources already tested requires change in TG The solution of the issue requires a change in TG
Milestone

Comments

@ulbrichtd
Copy link

Hi,

currently the validation of GML in the data theme Statistical Unit (Vector) fails when "gml:Surface" is used to characterize the area, i.e. the test "su-vector-as.b.2: Area Statistical Units" fails with the message "Check that the reference geometry of an area statistical units is a GM_MultiSurface.".

According to the specification for Statistical Unit ( https://inspire.ec.europa.eu/documents/Data_Specifications/INSPIRE_DataSpecification_SU_v3.0.pdf ) the UML class diagram for "Vector package" (figure 7 in section 5.3.1.2.3) suggests that GM_Object is allowed to describe the geometry.

I think the validation test is to strict and should allow gml:Surface.

Link to the data file: https://fbinter.stadt-berlin.de/fb/atom/SU/SU_BLK.zip
Link to the test report: SU_BLK_2021_06_29_Test.zip

Best regards and many thanks
Damian

@fabiovinci
Copy link
Collaborator

Dear @ulbrichtd,

we will investigate the check performed by the validator since your encoding should be ok.

As you mentioned the dataType of the geometry element is GM_Object, there is a specific constraint for the spatial object type VectorStatisticalUnit which states: "Vector statistical units with a reference geometry instance of GM_MultiSurface must be instances of the specialised class AreaStatisticalUnit.", but in your case, a "gml:Surface" geometry should be valid for the spatial object type AreaStatisticalUnit.

@fabiovinci
Copy link
Collaborator

Dear @ulbrichtd,

I had a deep look at the ATS and the related constraints defined by the IR 1089 and its amendment Commission Regulation (EU) No 1253/2013 defines a constraint about the geometry type of the AreaStatisticalUnit feature type.
See below:

image

The test in the validator reflects this constraint, although it is probably not well formulated since it is a constraint but makes use of the verb "should", which is, in general, used for recommendations.

Moreover, this constraint is not present in either the TG or the UML.

I think we can move the discussion to the TG repository, opening an issue for the inclusion of the constraint in the TG and asking feedback about its implementation, i.e. if it can be considered as a recommendation.

Could you please open the relevant issue in the TG repository?

@fabiovinci fabiovinci added discussion This is a discussion about the Validator, any comment is welcome help wanted Extra attention is needed labels Mar 7, 2022
@dperezBM dperezBM added the ready for testing Solution provided to reporter or developed & deployed in staging (or beta), waiting for testing label Mar 11, 2022
@arantzaetxebarria arantzaetxebarria removed the ready for testing Solution provided to reporter or developed & deployed in staging (or beta), waiting for testing label Mar 11, 2022
@fabiovinci fabiovinci added the requires change in TG The solution of the issue requires a change in TG label Mar 14, 2022
@fabiovinci
Copy link
Collaborator

According to the conclusions of the related TG issue, the related ATS has been modified and the test will be relaxed in the Validator.

@fabiovinci fabiovinci added under development and removed help wanted Extra attention is needed discussion This is a discussion about the Validator, any comment is welcome labels Apr 11, 2022
@arantzaetxebarria
Copy link
Collaborator

Dear @ulbrichtd

We have done the changes in the ETS in order to relax the test, now you can test it in staging environment. Let us know if all is correct, thanks in advance.

Regards,

Arantza

@arantzaetxebarria arantzaetxebarria added ready for testing Solution provided to reporter or developed & deployed in staging (or beta), waiting for testing and removed under development labels May 11, 2022
@ulbrichtd
Copy link
Author

Thank you for the fix. The validator in the staging area accepts now files with "su-vector:geometry/gml:Surface" and "su-vector:geometry/gml:MultiSurface".

Best regards,
Damian

@arantzaetxebarria
Copy link
Collaborator

Dear @ulbrichtd

The issue will remain open until the next release 2022.2 when the changes will be put into the production environment.

Regards

@arantzaetxebarria arantzaetxebarria added solved Solution developed and accepted, not yet deployed non-breaking change The change makes tests less restrictive and it has no impact on resources already tested and removed ready for testing Solution provided to reporter or developed & deployed in staging (or beta), waiting for testing labels May 11, 2022
@arantzaetxebarria arantzaetxebarria modified the milestones: 2022.1, 2022.2 May 11, 2022
@fabiovinci fabiovinci added deployed in reference validator Solution deployed in production and removed solved Solution developed and accepted, not yet deployed labels Jun 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deployed in reference validator Solution deployed in production non-breaking change The change makes tests less restrictive and it has no impact on resources already tested requires change in TG The solution of the issue requires a change in TG
Projects
None yet
Development

No branches or pull requests

4 participants