Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

All data specifications - certain codelist identifiers contain the wrong value "codeList" instead of "codelist" #4

Closed
fabiovin opened this issue Apr 20, 2021 · 7 comments · Fixed by #167 or #180
Labels
endorsed The change proposal is endorsed by the MIG.
Milestone

Comments

@fabiovin
Copy link
Contributor

The identifiers of the codelists, i.e. the URL pointing to the INSPIRE registry, are wrong because they contain the value "codeList" with an uppercase "L".
The right values are with the lowercase.

See the related issues in the Registry helpdesk and in the Validator helpdesk.

Any reporting of the same error in other TGs is more than welcome.

@heidivanparys
Copy link
Collaborator

All TGs should be checked for this issue. A quick check of some data specifications shows me that at least the data specifications for Addresses and Protected Sites have the same issue, even in the boilerplate text:

image

From INSPIRE-MIF/helpdesk-validator#407 (comment)

The URL in camel case is an old and wrong URL that was available when the INSPIRE registry was firstly released.
It has then been corrected to the lowercase one. The camel case version has been kept in order to guarantee the backward compatibility.

Do we have a reference to a decision that clearly states that the lowercase version is the one to be used?

@heidivanparys heidivanparys added for INSPIRE CT The change proposal is to be assessed by the INSPIRE CT. approved labels Jul 1, 2021
@heidivanparys
Copy link
Collaborator

heidivanparys commented Jul 1, 2021

Subgroup meeting 01-07-2021: issue presented, no objection from the group to move it further in the governance process.

@heidivanparys heidivanparys changed the title EF - Codelist identifiers contain the wrong value "codeList" Data specifications - certain codelist identifiers contain the wrong value "codeList" instead of "codelist" Jul 1, 2021
@heidivanparys
Copy link
Collaborator

I updated the title of this issue to reflect that this is applicable to more data specifications than just EF.

@MarcoMinghini
Copy link
Contributor

The INSPIRE CT approved the change proposal during today's meeting. In the next step, the proposal will be moved to the MIG for the final endorsement.

@MarcoMinghini MarcoMinghini added for INSPIRE MIG The change proposal is to be assessed by the INSPIRE MIG. and removed for INSPIRE CT The change proposal is to be assessed by the INSPIRE CT. labels Jul 6, 2021
@MarcoMinghini
Copy link
Contributor

The INSPIRE MIG approved the change proposal, since no objections were raised during the two week scrutiny period from July 12 to July 26, 2021. The change can be now implemented.

@MarcoMinghini MarcoMinghini added endorsed The change proposal is endorsed by the MIG. and removed approved for INSPIRE MIG The change proposal is to be assessed by the INSPIRE MIG. labels Aug 6, 2021
@fabiovinci fabiovinci added this to the 2023.2 milestone Jul 5, 2023
@fabiovinci fabiovinci linked a pull request Jul 20, 2023 that will close this issue
@fabiovinci
Copy link
Collaborator

The fix was introduced to the following TGs: EF, EL, GE, HY, PS, SD, US, during the release 2023.2.
The issue will remain open as a placeholder to apply the same fix to the TGs that will be converted and published in the next releases.

@fabiovinci fabiovinci removed this from the 2023.2 milestone Jul 31, 2023
@fabiovinci fabiovinci added the for JRC The change proposal is to be handled by the JRC. label Nov 29, 2023
@fabiovinci fabiovinci added this to the 2024.1 milestone Dec 1, 2023
@fabiovinci fabiovinci removed the for JRC The change proposal is to be handled by the JRC. label Dec 1, 2023
@fabiovinci fabiovinci linked a pull request Jan 31, 2024 that will close this issue
@fabiovinci
Copy link
Collaborator

The fix is introduced to the following TGs: AF, HB, HH, PF, and TN during the release 2024.1.
The issue will remain open as a placeholder to apply the same fix to the TGs that will be converted and published in the next releases.

@fabiovinci fabiovinci modified the milestones: 2024.1, 2024.2 Feb 8, 2024
@fabiovinci fabiovinci changed the title Data specifications - certain codelist identifiers contain the wrong value "codeList" instead of "codelist" All data specifications - certain codelist identifiers contain the wrong value "codeList" instead of "codelist" Jun 27, 2024
@fabiovinci fabiovinci linked a pull request Jul 12, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
endorsed The change proposal is endorsed by the MIG.
Projects
None yet
4 participants