Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Apache Pulsar protocol for SDK broker communiation #6

Open
marshallmcdonnell opened this issue Jul 2, 2024 · 1 comment
Open
Assignees

Comments

@marshallmcdonnell
Copy link
Collaborator

marshallmcdonnell commented Jul 2, 2024

Create examples for pulsar here:

Then, this will pick up the end-2-end test of the example. Add pulsar run_example_test here:

Then implement the broker client for pulsar here:

@marshallmcdonnell marshallmcdonnell self-assigned this Jul 2, 2024
@Lance-Drane
Copy link
Collaborator

Regarding the binary encoding issue, Pulsar is one of the protocols which supports protocol-level headers, so support will be guaranteed to continue once we add it.

Until that issue is tackled, I wouldn't worry too much about the precise implementation details, as the BrokerClient interface is still too narrow (publish() only accepts a raw byte payload, the subscribe() callback functions will still only provide the raw byte payloads, etc.).

Once the general APIs have been defined for other protocols, I don't expect it would be difficult at all to refactor the Pulsar logic to send metadata in the headers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants