Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parallel Edits/Publishing result in unclear errors/abandoned lock #10793

Closed
qqmyers opened this issue Aug 22, 2024 · 0 comments · Fixed by #10794
Closed

Parallel Edits/Publishing result in unclear errors/abandoned lock #10793

qqmyers opened this issue Aug 22, 2024 · 0 comments · Fixed by #10794
Labels
Type: Bug a defect
Milestone

Comments

@qqmyers
Copy link
Member

qqmyers commented Aug 22, 2024

What steps does it take to reproduce the issue?
Parallel UI edits to a dataset (i.e. from two browser pages opened to the same dataset, or separate browsers/users, etc.) result in the second one showing an error message noting the edit failed without any useful explanation. The error also returns the user to the main dataset page from the metadata edit pane, causing them to lose any information they had just types.
Similarly, if a user tries to publish a dataset version that has been updated elsewhere since they opened the dataset page, a message saying the publish method failed is shown (with no clear explanation as to why or how to recover). However, in this case the message is only shown briefly as a publish lock is added to the dataset and the error message disappears the first time the page refreshes to see if the lock has been removed. Further, since the Publish attempt failed, the lock remains until removed by an admin.

As discussed w.r.t. managing this in the SPA, there are a range of improvements that could be made, from simply creating clearer error messages, with some guidance as to how to proceed, to trying to identify what has changed and allowing the user to proceed if they agree the changes are consistent with their own edits/that publishing with those changes is OK.

Since these errors are being seen in the wild now (and are possibly a source of mystery dataset locks), I'll create a PR that will provide better error messages in these two cases and avoid leaving the publish lock on the dataset.

  • When does this issue occur?
    Edit/Edit or Edit/Publish done in parallel on two copies of the dataset page

Which version of Dataverse are you using?
6.3/develop

Any related open or closed issues to this bug report?

Screenshots:

No matter the issue, screenshots are always welcome.

To add a screenshot, please use one of the following formats and/or methods described here:

Are you thinking about creating a pull request for this issue?
Help is always welcome, is this bug something you or your organization plan to fix?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug a defect
Projects
None yet
2 participants