Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Improve Dataset version differencing performance #10814

Closed
qqmyers opened this issue Aug 29, 2024 · 0 comments · Fixed by #10818
Closed

Feature Request: Improve Dataset version differencing performance #10814

qqmyers opened this issue Aug 29, 2024 · 0 comments · Fixed by #10818
Labels
Type: Feature a feature request
Milestone

Comments

@qqmyers
Copy link
Member

qqmyers commented Aug 29, 2024

Overview of the Feature Request The DatasetVersionDifference class uses some double loops over FileMetadata/DataFiles from the old and new versions which are known to be inefficient (the code has a todo). Making this faster would improve the performance of editing a dataset with many files as well as displaying the versions table on the dataset page.

Are you thinking about creating a pull request for this feature?
PR to follow

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Feature a feature request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants