Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update the conditions to display image_url in Solr search results for file type #10886

Merged
merged 6 commits into from
Oct 25, 2024
Merged

Update the conditions to display image_url in Solr search results for file type #10886

merged 6 commits into from
Oct 25, 2024

Conversation

stevenwinship
Copy link
Contributor

What this PR does / why we need it: fixes the conditions in which the visibility of the image_url field is included in the search results.

Which issue(s) this PR closes:#10875

Closes #10875

Special notes for your reviewer:

Suggestions on how to test this:

Does this PR introduce a user interface change? If mockups are available, please link/include them here: No

Is there a release notes update needed for this change?: No

Additional documentation: See #10855

@stevenwinship stevenwinship self-assigned this Sep 26, 2024
@stevenwinship stevenwinship added Size: 10 A percentage of a sprint. 7 hours. SPA These changes are required for the Dataverse SPA GREI Re-arch Issues related to the GREI Dataverse rearchitecture SPA.Q3 Not related to any specific Q3 feature FY25 Sprint 7 FY25 Sprint 7 (2024-09-25 - 2024-10-09) labels Sep 26, 2024
@coveralls
Copy link

coveralls commented Sep 26, 2024 •
edited
Loading

Coverage Status

coverage: 20.868% (-0.001%) from 20.869%
when pulling cb6e44f on 10875-update-conditions-to-display-image_url
into a0cb73d on develop.

@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
1 similar comment
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@stevenwinship stevenwinship removed their assignment Sep 27, 2024
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
1 similar comment
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@pdurbin pdurbin self-assigned this Oct 2, 2024
pdurbin
pdurbin reviewed Oct 2, 2024
View reviewed changes
Copy link
Member

@pdurbin pdurbin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I made a small tweak to the release note. API tests didn't run so I'm holding on to this to see if they pass this time. They're running now.

@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 2, 2024

📦 Pushed preview images as

ghcr.io/gdcc/dataverse:10875-update-conditions-to-display-image-url

ghcr.io/gdcc/configbaker:10875-update-conditions-to-display-image-url

🚢 See on GHCR. Use by referencing with full name as printed above, mind the registry name.

@pdurbin
Copy link
Member

pdurbin commented Oct 3, 2024

API tests didn't run. At standup @stevenwinship said he'd take a look (thanks): https://jenkins.dataverse.org/job/IQSS-Dataverse-Develop-PR/job/PR-10886/5/testReport/

@stevenwinship
Copy link
Contributor Author

I re-ran the tests and they all passed.
https://jenkins.dataverse.org/job/IQSS-Dataverse-Develop-PR/job/PR-10886/6/

@stevenwinship stevenwinship removed their assignment Oct 3, 2024
pdurbin
pdurbin approved these changes Oct 3, 2024
View reviewed changes
Copy link
Member

@pdurbin pdurbin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure enough! Thanks! Approved!

@pdurbin pdurbin removed their assignment Oct 3, 2024
@GPortas GPortas added the SPA.Q4 Not related to any specific Q4 feature label Oct 9, 2024
@GPortas GPortas removed the SPA.Q3 Not related to any specific Q3 feature label Oct 9, 2024
@pdurbin pdurbin added the Type: Bug a defect label Oct 9, 2024
@ofahimIQSS ofahimIQSS self-assigned this Oct 15, 2024
@ofahimIQSS
Copy link
Contributor

@stevenwinship Uncovered an issue while testing this PR. Collection Thumbnails aren't displayed on homepage when adding a logo, thumbnail, and footer images to a collection.

  1. Create a new Collection
  2. Edit Collection> Theme + Widgets
  3. Upload Logo, Thumbnail, and Footer Images
  4. Publish Collection
  5. Navigate to homepage --- here is where the issue lies: Notice that the thumbnail still displays default Dataverse Collection thumbnail instead of what was just uploaded.

@stevenwinship
Copy link
Contributor Author

RE: Navigate to homepage --- here is where the issue lies: Notice that the thumbnail still displays default Dataverse Collection thumbnail instead of what was just uploaded.

This issue exists in develop branch and is not caused by this PR

@ofahimIQSS ofahimIQSS mentioned this pull request Oct 23, 2024
Closed
@cmbz cmbz added FY25 Sprint 8 FY25 Sprint 8 (2024-10-09 - 2024-10-23) FY25 Sprint 9 FY25 Sprint 9 (2024-10-23 - 2024-11-06) labels Oct 23, 2024
@ofahimIQSS
Copy link
Contributor

Confirmed testing with Steve - no issues found with PR. Merging
Testing of 10886.docx

@ofahimIQSS ofahimIQSS merged commit 9faf32e into develop Oct 25, 2024
19 checks passed
@ofahimIQSS ofahimIQSS deleted the 10875-update-conditions-to-display-image_url branch October 25, 2024 16:41
@ofahimIQSS ofahimIQSS removed their assignment Oct 25, 2024
@pdurbin pdurbin added this to the 6.5 milestone Oct 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@pdurbin pdurbin pdurbin approved these changes

Assignees
No one assigned
Labels
FY25 Sprint 7 FY25 Sprint 7 (2024-09-25 - 2024-10-09) FY25 Sprint 8 FY25 Sprint 8 (2024-10-09 - 2024-10-23) FY25 Sprint 9 FY25 Sprint 9 (2024-10-23 - 2024-11-06) GREI Re-arch Issues related to the GREI Dataverse rearchitecture Original size: 10 Size: 10 A percentage of a sprint. 7 hours. SPA.Q4 Not related to any specific Q4 feature SPA These changes are required for the Dataverse SPA Type: Bug a defect
Projects
IQSS Dataverse Project
Status: Done 🧹
Milestone
6.5
Development

Successfully merging this pull request may close these issues.

Update the conditions to display image_url in Solr search results for file type
6 participants
@stevenwinship @coveralls @pdurbin @ofahimIQSS @GPortas @cmbz