Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom File Handling - rsync files #3351

Closed
djbrooke opened this issue Sep 13, 2016 · 4 comments
Closed

Custom File Handling - rsync files #3351

djbrooke opened this issue Sep 13, 2016 · 4 comments

Comments

@djbrooke
Copy link
Contributor

djbrooke commented Sep 13, 2016

Certain buttons or other options may be disabled for files added to dataverse using rsync.

@pdurbin
Copy link
Member

pdurbin commented Sep 13, 2016

During the 2016-09-08 SBGrid Sprint Planning meeting ( https://docs.google.com/document/d/1wWSdKUOGA1L7UqFsgF3aOs8_9uyjnVpsPAxk7FObOOI/edit ) this issue was given an effort level of "5" but I feel like this issue is highly intertwined with #3350 with regard to "download all as zip".

This issue raises several concerns I expressed at the 2016-09-07 demo because those buttons we're talking about hiding do very important things in the system such as versioning of files and restricting files. I called this "Tradeoffs" during the talk: https://docs.google.com/presentation/d/1cOOLylj5mMNllE8--Gg65lG6HS1Ih4oGypnWLeh0h4k/edit?usp=sharing

screen shot 2016-09-13 at 11 28 55 am

The thing to keep in mind is that for the migration story from https://data.sbgrid.org that @bmckinney and @pameyer are working on, they're fine with hiding these buttons because their customers:

  • Don't need versioning of files since the files come off an instrument and don't change.
  • Don't need to restrict data since the data is CC0 licensed.
  • Don't need to download all as zip because they'll use rsync instead.

The other day @mheppler said, "We're trying not to have a 100% custom experience for your users." I agree with this too, at least in the long run. In the short run, however, do we make these tradeoffs? Do we say that if you use the rsync feature, you can't version files or restrict files? Do we disable the buttons? What's in scope for this issue? I'm afraid I have more questions than answers so I'm assigning this to @djbrooke @scolapasta @bmckinney and myself to discuss further.

@pdurbin
Copy link
Member

pdurbin commented Sep 15, 2016

@bmckinney @scolapasta @djbrooke and I discussed this issue today but decided to leave it in the backlog for now. We still need to figure out what the plan is for changing the code.

@pdurbin pdurbin added the SBGrid label Oct 7, 2016
@pdurbin pdurbin removed their assignment Dec 19, 2016
@djbrooke
Copy link
Contributor Author

Closing. Changes will be made in #3348 or in issue spawned from there.

@pdurbin
Copy link
Member

pdurbin commented Jun 21, 2017

All the non-restricting of files is part of #3776 as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants