Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-Index properly after deletion #372

Closed
eaquigley opened this issue Jul 9, 2014 · 4 comments
Closed

Re-Index properly after deletion #372

eaquigley opened this issue Jul 9, 2014 · 4 comments
Assignees

Comments

@eaquigley
Copy link
Contributor


Author Name: Michael Bar-Sinai (@michbarsinai)
Original Redmine Issue: 3787, https://redmine.hmdc.harvard.edu/issues/3787
Original Date: 2014-03-27
Original Assignee: Kevin Condon


Hello Phil,

Updating the index after deletion - I recommend adding code to the DeleteDataFile, DeleteDataset, and DeleteDataverse commands.
Another option, if possible, is to have a "start index of X" or "update index of X" command, and have these commands issue it after they are successful.


Related issue(s): #380
Redmine related issue(s): 3795


@eaquigley
Copy link
Contributor Author


Original Redmine Comment
Author Name: Philip Durbin (@pdurbin)
Original Date: 2014-03-31T16:46:10Z


So far indexing has always been an add/replace. Individual Solr documents have never been targeted for deletion.

We need to figure this out for datasets anyway (more on this in a bit) so I'm bumping up the priority and target version.

For datasets, we want the following deletion to happen:

  • when a released dataset gets a new draft version, continue to index the dataset as id:dataset_42 but create a new Solr document (private to the group per Deaccession: Allow owner to update forwarding link #3464) called id:dataset_42_draft
  • when the draft dataset gets released, delete id:dataset_42_draft

@eaquigley
Copy link
Contributor Author


Original Redmine Comment
Author Name: Philip Durbin (@pdurbin)
Original Date: 2014-04-28T20:33:33Z


Philip Durbin wrote:

So far indexing has always been an add/replace. Individual Solr documents have never been targeted for deletion.

The first Solr documents we started targeting for deletion were dataverses:

e59d123 on dataverse delete, also delete from Solr index #3787

Work on targeting datasets and files for deletion is ongoing in #3795.

@eaquigley
Copy link
Contributor Author


Original Redmine Comment
Author Name: Philip Durbin (@pdurbin)
Original Date: 2014-06-18T17:26:01Z


I believe this is all set as of the fix in #4129. I just tested in #4040, for example. Passing to QA.

@eaquigley eaquigley added this to the Dataverse 4.0: In Review milestone Jul 9, 2014
@eaquigley eaquigley modified the milestones: Dataverse 4.0: Beta 3, Dataverse 4.0: In Review Jul 15, 2014
@kcondon
Copy link
Contributor

kcondon commented Jul 23, 2014

Deleting dataset indexes properly, deleting file does not but opened separate ticket for that: #762

Closing this ticket for clarity.

@kcondon kcondon closed this as completed Jul 23, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants