Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dataset Page: Download button for tabular file has dropdown but is cut off if near the bottom of the list of files #3835

Closed
pdurbin opened this issue May 16, 2017 · 4 comments
Assignees
Labels
Type: Bug a defect User Role: Curator Curates and reviews datasets, manages permissions UX & UI: Design This issue needs input on the design of the UI and from the product owner

Comments

@pdurbin
Copy link
Member

pdurbin commented May 16, 2017

Originally reported by @rmo-cdsp at http://irclog.iq.harvard.edu/dataverse/2017-05-16#i_52784 for v. 4.6.1 build 69-1ed82ae

In the example below the last tabular file is "004_Nigeria-Cassava_Sociodemographic.tab" from https://dataverse.harvard.edu/dataset.xhtml?persistentId=doi:10.7910/DVN/29604 . Notice how the dropdown is hidden:

Dropdown cut off due to being at end of list of files

screen shot 2017-05-16 at 12 02 33 pm

What you should see is all the stuff in the drop down, such as for this file that's higher up in the file list:

Dropdown not cut off

screen shot 2017-05-16 at 12 00 24 pm

@pdurbin pdurbin added UX & UI: Design This issue needs input on the design of the UI and from the product owner Type: Bug a defect labels May 16, 2017
@dlmurphy
Copy link
Contributor

Just checked, and this bug is appearing on my own setup as well. One can work around the bug by opening the dropdown and then scrolling down while the dropdown is open. This workaround is definitely not intended behavior, it's very difficult to pull off, and it's not at all telegraphed to the user. This bug puts a significant roadblock in the way of half of the file's download options, so it strikes me as pretty significant.

@djbrooke djbrooke added ready and removed Backlog labels Jun 19, 2017
@pdurbin pdurbin added the User Role: Curator Curates and reviews datasets, manages permissions label Jul 3, 2017
@pdurbin
Copy link
Member Author

pdurbin commented Jul 7, 2017

@rbhatta99 took at look at the code this morning and has some ideas that we talked about. I asked him to get in touch with @mheppler .

@rbhatta99
Copy link
Contributor

@pdurbin i tried some things, but it broke the whole files table. So, @mheppler suggested we shelf it again for now.

@mheppler
Copy link
Contributor

mheppler commented Jul 7, 2017

@pdurbin @rbhatta99 I am just going to go ahead and close this issue, and add it to the long list of closed issues related to the scrollable datatable for files on the dataset pg (see #3404).

When this issue was first raised, I suggested it wasn't a bug because you can scroll the scrollable datatable and see the "cut off" menu options. Here is a screenshot of the exact same dataset referenced above with the menu options in full display.

screen shot 2017-07-07 at 5 05 37 pm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug a defect User Role: Curator Curates and reviews datasets, manages permissions UX & UI: Design This issue needs input on the design of the UI and from the product owner
Projects
None yet
Development

No branches or pull requests

5 participants