Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make "download as original" disappear from download options, when there is no saved original. #4796

Closed
landreev opened this issue Jun 28, 2018 · 3 comments
Assignees

Comments

@landreev
Copy link
Contributor

This is the small issue that Sonia asked us to patch in production 2 weeks ago, since it was kind of important-ish:
We were showing "download original" for every tabular file; even when there is no saved original.
This affects only a few tabular files - the oldest ones we grandfathered in from the VDC (!). But some of them also happen to be super important datasets and files.
(this may have been made worse somewhat recently, when we rearranged the order of download options in the pulldown, making "original" the top option - so the users are now more likely to click it...)
So anyway, the fix is super simple - I'm creating a PR...

@pdurbin
Copy link
Member

pdurbin commented Jun 28, 2018

I'm troubled that the original files are missing but I guess there's nothing that can be done about that. Pull request #4797 seems fine. Thanks for creating it, @landreev even while on vacation!

@kcondon kcondon self-assigned this Jun 29, 2018
@kcondon
Copy link
Contributor

kcondon commented Jun 29, 2018

OK, so I have removed the original file from an ingested tabular file and still see download original in list. Should I? It seems like I shouldn't.

@kcondon
Copy link
Contributor

kcondon commented Jun 29, 2018

Turns out the trigger is not a missing file but originalfileformat='' in the datatable table, as per the code. Works.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants