Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search: Newly created datasets or newly added cvv fields are not searchable #8633

Closed
kcondon opened this issue Apr 21, 2022 · 4 comments · Fixed by #8624
Closed

Search: Newly created datasets or newly added cvv fields are not searchable #8633

kcondon opened this issue Apr 21, 2022 · 4 comments · Fixed by #8624
Milestone

Comments

@kcondon
Copy link
Contributor

kcondon commented Apr 21, 2022

Noticed in v5.10.1.

CVV fields such as Subject in the Citation block are not searchable for newly created datasets or if the CVV field was newly added where it had not existed before.

Steps to reproduce:

  1. For convenience in limiting results, create a new dataset, then create a new dataset, add Chemistry as the subject, save
  2. Type Chemistry into basic search or select it in advanced search, search on it. No results found.
  3. Choose an existing dataset that is older, search on subject, it should be found.
@pdurbin
Copy link
Member

pdurbin commented Apr 21, 2022

Yuck. You're right. If I use the "Advanced Search" page to construct a query for datasets with "Chemistry" as the subject, I get no results:

Screen Shot 2022-04-21 at 3 58 50 PM

Screen Shot 2022-04-21 at 3 58 23 PM

By running the query script to dump the Solr data and grep for Chemistry I can find my dataset:

scripts/search/query | grep Chemistry
        "subject_ss":["Chemistry"],

Does this mean that we somehow changed the search field from subject to subject_ss? This strikes me as backward incompatible (think OAI-PMH sets or saved searches). At the very least, field needs to line up with what's filled in by the "Advanced Search" page.

This pull request that was merged as part of 5.10.1 seems related, at least:

I thought to test this because of the post by @DieuwertjeBloemen at https://groups.google.com/g/dataverse-community/c/mRNhl-E6ris/m/6opD_S8mKgAJ about accessRights vs accessRights_s and language vs language_ss.

@ErykKul
Copy link
Collaborator

ErykKul commented Apr 22, 2022

Fixed in the linked pull request #8624 :
image

@ErykKul
Copy link
Collaborator

ErykKul commented Apr 22, 2022

After merging reindexing will berequired.

@mreekie
Copy link

mreekie commented Apr 27, 2022

sprint:

  • The behavior is well understood.
  • The solution is not clear.
  • there is an attached PR.
  • Jim suggests that this may be an issue he introduced.
  • sounds like it started in 5.10 or 5.10.1
  • might be specific to controlled vocabularied.
  • small. There is a PR against this that needs to be checked.

We will remove this from the board
The attached PR will take the place of this in the sprint.
The attached PR is linked to this as closing it.

@pdurbin pdurbin added this to the 5.11 milestone Jun 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants