Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QA for Fundreg and ROR support #9973

Closed
cmbz opened this issue Oct 4, 2023 · 3 comments
Closed

QA for Fundreg and ROR support #9973

cmbz opened this issue Oct 4, 2023 · 3 comments
Assignees
Labels
NIH GREI Aim 1 Tasks needed to advance the work of supporting large datasets NIH OTA: 1.2.1 2 | 1.2.1 | Design and implement integration with controlled vocabularies | 5 prdOwnThis is an it... Size: 3 A percentage of a sprint. 2.1 hours. Type: Feature a feature request
Milestone

Comments

@cmbz
Copy link

cmbz commented Oct 4, 2023

Overview of the QA Request

What existing behavior do you want investigated?

@cmbz cmbz added the NIH OTA: 1.2.1 2 | 1.2.1 | Design and implement integration with controlled vocabularies | 5 prdOwnThis is an it... label Oct 4, 2023
@cmbz cmbz moved this to SPRINT- NEEDS SIZING in IQSS Dataverse Project Oct 4, 2023
@cmbz cmbz added the NIH GREI Aim 1 Tasks needed to advance the work of supporting large datasets label Oct 4, 2023
@cmbz cmbz added the Size: 3 A percentage of a sprint. 2.1 hours. label Oct 10, 2023
@cmbz
Copy link
Author

cmbz commented Oct 10, 2023

2023/10/10: Adding size 3 following discussion. Opportunity to review UI for future enhancements.

@cmbz cmbz moved this from SPRINT- NEEDS SIZING to SPRINT READY in IQSS Dataverse Project Oct 11, 2023
@cmbz cmbz moved this from SPRINT READY to Clear of the Backlog in IQSS Dataverse Project Oct 12, 2023
@pdurbin pdurbin added Type: Suggestion an idea Type: Feature a feature request and removed Type: Suggestion an idea labels Oct 13, 2023
@kcondon kcondon self-assigned this Oct 16, 2023
@kcondon
Copy link
Contributor

kcondon commented Oct 17, 2023

@qqmyers I could use some help setting up the fundreq and ror CVOC on demo for real as it would be deployed to prod, not as a test metadatablock.

Can you provide the necessary config files for this specific case and whatever additional steps I need to perform?

I've read the examples, https://github.com/gdcc/dataverse-external-vocab-support , and saw the steps:

To enable external voabulary support on the example metadata block provided you need to:

Install the custom metadata block
Update your solr schema to include the custom fields
Set the :CVocConf setting - use the /examples/config/cvoc-conf.json as the value
Enable the use of this new block in your test Dataverse collection (e.g. Use the Edit/General Information menu item, /Metadata Fields section to add the block/specific fields.)
Add any desired terms from the example block to the Browse/Search Facets list (same Edit/General Information menu item)

-The first step re: custom metadata block, seeing as it would be an existing block ie. Citation, does it need to be updated to alow controlled vocab? Can I get the tsv for that?
-Since it isn't a new custom block containing new fields, the solr step can be skipped, right?
-I tried setting :CVocConf by combining the .json files into an array but I am sure my file is lacking something. I know you provided a schema to compare against but tbh, it's not something I'm up to speed on.
-The other two steps are again only for a new block so can be skipped. Seems like the only steps in our use case are maybe updating the citation block to enable cvoc and uploading the correct json file to enable fundreq and ror, assuming those scripts are hosted/served remotely. Is that correct?

@kcondon
Copy link
Contributor

kcondon commented Oct 17, 2023

Thanks @qqmyers and @landreev, I was able to configure this on test and demo. The main changes needed were:

  1. create a cvoc_fundreg_ror.json that includes the json from the individual files into an array:
    cvocconf_fundreq_ror.json

  2. Move the .js scripts from the gdcc repo to /var/www/http/cvoc/js and make the owner dataverse

  3. Edit ssl.conf and add Rewrite rules to skip these files from being forwarded to payara, ie. serve from apache:
    RewriteRule ^/cvoc/js/cvocutils.js /var/www/html/cvoc/js/cvocutils.js
    RewriteRule ^/cvoc/js/fundreg.js /var/www/html/cvoc/js/fundreg.js
    RewriteRule ^/cvoc/js/ror.js /var/www/html/cvoc/js/ror.js

Status of this issue is resolved:

  1. deployed to demo, 2. can set author affiliation (ror) and grantfunding/funder fields using controlled vocab. 3. The last item in Iqss/9150 handle fundreg reqs for ext cvv #9402 said all major issues resolved and needs UX post spa 4. Will communicate demo availability to dvn-core shortly 5. The path it took was winding but I think it is mostly delivered but needing UX at a later date. I think there is some useful info in the issues found as in what to look out for, later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
NIH GREI Aim 1 Tasks needed to advance the work of supporting large datasets NIH OTA: 1.2.1 2 | 1.2.1 | Design and implement integration with controlled vocabularies | 5 prdOwnThis is an it... Size: 3 A percentage of a sprint. 2.1 hours. Type: Feature a feature request
Projects
Status: No status
Status: Done
Development

No branches or pull requests

3 participants