Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refl: string constants are not displayed correctly #8227

Closed
1 task
rerpha opened this issue Feb 14, 2024 · 2 comments
Closed
1 task

refl: string constants are not displayed correctly #8227

rerpha opened this issue Feb 14, 2024 · 2 comments

Comments

@rerpha
Copy link
Contributor

rerpha commented Feb 14, 2024

As a reflectometry user I would like to have a string constant and I would like it to be displayed correctly.

Currently these are given a type of "float_type" which causes the GUI to display each character in the char array as hex.

This was noticed yesterday when helping INTER out with adding some string constants, which we noticed weren't displayed correctly.

Acceptance criteria

  • String constants are displayed correctly

as you can see in this pic of INTER's constants tab, "OPI" and "slits" are strings that are not displayed correctly.
image

@rerpha
Copy link
Contributor Author

rerpha commented Feb 14, 2024

ISISComputingGroup/EPICS-refl#56
ISISComputingGroup/ibex_gui#1679
#8228

To review:

  • check out NDXINTER's config branch
  • start ibex server
  • go to the reflectometry perspective -> constants tab
    and check that the "OPI" constant says "INTER"
image

@Chsudeepta
Copy link
Contributor

Code reviewed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Status: Done
Development

No branches or pull requests

4 participants