Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

McLennan: make IOC work if crate is power cycled #8253

Assignees
Labels

Comments

@FreddieAkeroyd
Copy link
Member

FreddieAkeroyd commented Mar 6, 2024

As a user of the mclennan I would like the IOC to continue to work if the crate is power cycled, tiem was lost recent;y on an instrument due to this as it was not noticed the encoder ratio had reverted to a previous NVRAM value. Varios options are possibe:

  • we send all necessary parameters on a move, however this may mean affect readbacks until a move?
  • we have a monitor thread to check values and resend / save
  • Mclennans are the most likely things to be power cycled as they're temporary and get moved around
  • Possibly have a monitor on power cycle like the galils, but instead of raising to nagios it simply resends the parameters

Acceptance Criteria

  • Investigate how to identify a power cycle
    • check manuals for uptime command or similar
  • on power cycle of a mclennan crate ibex control is not affected

How to Test

  • there is a mclennan crate in the office, make sure this works against hardware

Time in planning

38:20 4/4/24

@FreddieAkeroyd
Copy link
Member Author

Check BA command - migth be used by Vi. Vi saved them on home.

@LowriJenkins LowriJenkins added the 8 label Apr 4, 2024
@KathrynBaker KathrynBaker moved this to Backlog in PI_2024_02 Apr 4, 2024
@github-actions github-actions bot added the ready label Apr 4, 2024
@KathrynBaker KathrynBaker added this to the SPRINT_2024_04_04 milestone Apr 4, 2024
@isaachilly isaachilly self-assigned this Apr 17, 2024
@KathrynBaker KathrynBaker moved this from Backlog to In Progress in PI_2024_02 Apr 19, 2024
@isaachilly
Copy link
Contributor

isaachilly commented May 2, 2024

To test

  1. Check the code quality is acceptable.
  2. Check the tests are logical and pass.
  3. Update test framework & device emulator submodule of epics
  4. Already tested on device

PRs linked in dev tab

@isaachilly isaachilly moved this from In Progress to Review in PI_2024_02 May 2, 2024
@isaachilly isaachilly linked a pull request May 2, 2024 that will close this issue
@rerpha
Copy link
Contributor

rerpha commented May 3, 2024

if you really want to test on office mclennan, settings are 9600,7,e,1, no flow control.

Check MOXA serial settings if above don't work.

@FreddieAkeroyd
Copy link
Member Author

This is different to what is said in https://github.com/ISISComputingGroup/ibex_developers_manual/wiki/McLennan-motors#office-mclennan-settings but i know we have two mclennan creates. Can we either make them both the same and in agreement with the wiki (changing as necessary), or label the crates each with their settings

@isaachilly
Copy link
Contributor

isaachilly commented May 3, 2024

Yes the settings on the actual board were changed during mine and David's attempts to make the crates talk. They can be put back or as you say can change wiki etc and label creates as well.

@rerpha
Copy link
Contributor

rerpha commented May 3, 2024

now labelled, wiki updated as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment