Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Galil: indicate better that communications has failed #8524

Closed
FreddieAkeroyd opened this issue Oct 2, 2024 · 4 comments
Closed

Galil: indicate better that communications has failed #8524

FreddieAkeroyd opened this issue Oct 2, 2024 · 4 comments
Assignees
Labels

Comments

@FreddieAkeroyd
Copy link
Member

As a developer and user i would like it to be clearer that a motor has failed to communicate. At the moment the motor does not go into alarm when comms fails, certainly for a galil but may be true for all motors. Concentrate on Gail for this ticket. The likely reason is that for a galil we read from the cached data record, so it stops upadting but we can still read the previous cache. So we need to propagate it has failed to update into the alarm status of parameters.

Acceptance Criteria

disconnecting communications to a galil controller results in motor record going into alarm

@FreddieAkeroyd FreddieAkeroyd changed the title Motors: indicate better that communications has failed Galil: indicate better that communications has failed Oct 2, 2024
@KathrynBaker KathrynBaker moved this to Backlog in PI_2024_08 Oct 4, 2024
@davidkeymer davidkeymer self-assigned this Oct 8, 2024
@davidkeymer davidkeymer moved this from Backlog to In Progress in PI_2024_08 Oct 8, 2024
@rerpha rerpha self-assigned this Oct 11, 2024
@rerpha
Copy link
Contributor

rerpha commented Oct 11, 2024

@FreddieAkeroyd David and I have been working on this this morning. There are two ways to skin a cat I think! See comments in https://github.com/ISISComputingGroup/EPICS-galil/compare/Ticket8524?expand=1

we can either alarm after 3 attempts (like how we disconnect after 3 attempts) or alarm every time. I'm not sure I have much of a preference, but either way propagates the alarm to the motor record and clears when it's successful again.

I'm also nt sure if this ticket covers the "disconnection at startup" - currently that doesn't cause an alarm either. We might have a quick look and see if we can propagate an alarm in that case too, though i dont think its technically in scope of this ticket?

@FreddieAkeroyd
Copy link
Member Author

I don't know how often we have the odd timeout, so it may be best to alarm after 3 attempts like the disconnect so we don't cause parameters to occasionally alarm and then immediately clear and then get a call from users. Would be good if you could also cover the "disconnection on startup" too for completeness.

@davidkeymer
Copy link
Contributor

I don't know how often we have the odd timeout, so it may be best to alarm after 3 attempts like the disconnect so we don't cause parameters to occasionally alarm and then immediately clear and then get a call from users. Would be good if you could also cover the "disconnection on startup" too for completeness.

Thanks for your input, Freddie. Yes, that's what we were thinking too!

@rerpha
Copy link
Contributor

rerpha commented Dec 10, 2024

@rerpha rerpha moved this from In Progress to Review in PI_2024_08 Dec 10, 2024
@github-project-automation github-project-automation bot moved this from Review to Done in PI_2024_08 Dec 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
No open projects
Status: Done
Development

No branches or pull requests

6 participants