Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HIFI: migrate scripts [Timebox: 1 Day] #8546

Open
4 tasks
LilithCole opened this issue Oct 22, 2024 · 2 comments
Open
4 tasks

HIFI: migrate scripts [Timebox: 1 Day] #8546

LilithCole opened this issue Oct 22, 2024 · 2 comments
Labels

Comments

@LilithCole
Copy link
Contributor

LilithCole commented Oct 22, 2024

Feature Description

As an instrument scientist, I would like to have all of my opengenie scripts converted to genie python so that I can continue to operate my instrument without issue post-migration.

Explanation

The current scripts being used to control the instrument in seci are written in opengenie, they must be converted to genie python in order to be used with IBEX. This will require collaborating with the instrument scientists to find out which scripts are most necessary, and assisting them with converting them.

Additional Information

See our Git Workflow.

  • Clearly explain to scientists the strict timing limits on discussions and actual conversion work.

Acceptance Criteria

  • A block of time (half a day?) is organised with instrument scientists in which to investigate their scripts
  • Necessary scripts are identified with instrument scientists
  • With the instrument scientists' assistance/whilst showing them how to do it, convert a selection of necessary scripts during the organised time
  • A further ticket is created for converting any remaining necessary scripts. Tell scientists that the same person may not be dealing with this second ticket.

How to Review

Before making a PR...

  • Provide verbose instructions for the reviewer to test your changes
  • Describe how you have implemented testing for this feature
  • Provide screenshots of the feature to help the reviewer if relevant

If not applicable, write "Not applicable"

...

To the reviewer: Make sure to update submodules!

Planning

10/01/25 - 00:16:45
28/11/24 - 00h43m

@LilithCole LilithCole changed the title [Instrument or device name, e.g. WISH]: [Brief description of request] HIFI: migrate scripts HIFI: migrate scripts Oct 22, 2024
@ISISBuilder ISISBuilder moved this to Backlog in PI_2024_08 Nov 27, 2024
@LilithCole LilithCole removed the status in PI_2024_08 Nov 27, 2024
@LilithCole LilithCole moved this to Backlog in PI_2024_08 Nov 27, 2024
@KathrynBaker KathrynBaker added for release Required for next release and removed for release Required for next release proposal labels Nov 27, 2024
@iangillingham-stfc
Copy link
Contributor

Make sure you talk to James to discuss which scripts need migrating, as some are not required.

@Tom-Willemsen
Copy link
Contributor

From #8401 (comment) :

  • Instrument scripts that enable/disable ZF:
    • On exiting ZF mode, should record the magnet current settings that were used to settle at zero to a file / PV or similar
    • On reentering ZF mode, the shim coils should first be set to the saved values, and then zeroing starts from there

@Tom-Willemsen Tom-Willemsen mentioned this issue Dec 4, 2024
5 tasks
@GRyall GRyall changed the title HIFI: migrate scripts HIFI: migrate scripts TIMEBOX: 1 Day Jan 10, 2025
@Chsudeepta Chsudeepta changed the title HIFI: migrate scripts TIMEBOX: 1 Day [Timebox: 1 Day]HIFI: migrate scripts Jan 10, 2025
@Chsudeepta Chsudeepta added the 5 label Jan 10, 2025
@GRyall GRyall changed the title [Timebox: 1 Day]HIFI: migrate scripts HIFI: migrate scripts [Timebox: 1 Day] Jan 10, 2025
@KathrynBaker KathrynBaker moved this to Backlog in PI_2025_02 Jan 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Backlog
Development

No branches or pull requests

5 participants