Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IOC log files: fix issue with garbled/misformatted output on restart with console command #8593

Closed
FreddieAkeroyd opened this issue Dec 8, 2024 · 2 comments
Assignees
Labels
5 for release Required for next release

Comments

@FreddieAkeroyd
Copy link
Member

When an IOC is restarted via the console command, the output written in the log file starts to contain control characters and also wraps at 80 columns, this makes debugging more difficult. This does not happen on a restart if console is not attached, or if e.g. telnet is attached to the procServ instead of console.

Acceptance criteria

  • after patch, console to ioc and restart it using control-x and output should remain well formatted

Notes

  • this didn't used to happen, but started to happen at some point in the past
@FreddieAkeroyd
Copy link
Member Author

So after a bit of digging around with terminal types and forkpty I discovered that this is due cygwin adding support for new windows pseudoterminals available in Windows 10 https://cygwin.com/pipermail/cygwin-developers/2019-April/011768.html, so the issue would have appeared when we moved to W10 and updated cygwin to a newer version. The new pseudoterminals are set at 80x25 initially and look like a real terminal, hence epics tries to use coloured output for errors. Previously it looked like a file and EPICS didn't use colour control characters. As not everything worked with the new API, cygwin later provided and option to disable this feature https://cygwin.com/pipermail/cygwin-cvs/2020q1/014268.html

@FreddieAkeroyd
Copy link
Member Author

Patches set disble_pcon option and also remove nodosfilewarning that no longer does anything

@FreddieAkeroyd FreddieAkeroyd changed the title IOC log files: fix issue with garbled/misformatted output on restrat IOC log files: fix issue with garbled/misformatted output on restart with console command Dec 8, 2024
@FreddieAkeroyd FreddieAkeroyd self-assigned this Dec 8, 2024
@FreddieAkeroyd FreddieAkeroyd moved this to Review in PI_2024_08 Dec 8, 2024
@FreddieAkeroyd FreddieAkeroyd added the for release Required for next release label Dec 9, 2024
@github-project-automation github-project-automation bot moved this from Review to Done in PI_2024_08 Dec 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
5 for release Required for next release
Projects
No open projects
Status: Done
Development

No branches or pull requests

3 participants